Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add authorization header for whep, for stream key #64

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

dnimon
Copy link
Contributor

@dnimon dnimon commented Nov 17, 2023

Servers like https://github.com/Glimesh/broadcast-box require an Authorization header to provide the stream key.

The whip client (https://github.com/Eyevinn/whip/blob/main/packages/sdk/src/WHIPProtocol.ts) supports providing an authkey and sends it to the header.

This PR does the same for the player for whep, to allow for the authorization header to be passed.

Copy link
Contributor

@birme birme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks

@birme birme merged commit 1a6ef27 into Eyevinn:main Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants