Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connecting API #5

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Connecting API #5

wants to merge 4 commits into from

Conversation

EzekielUtshudi
Copy link
Owner

  • use the API
  • Add redux-thunk
  • Fetch book list from Bookstore API on Books page load
  • Refactor your add book and remove book features
  • Add a book and remove a book

Copy link

@Mihndim2020 Mihndim2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED!!! 🎉 🎉 🎉 🍾 🍾 🍾

Hi @EzekielUtshudi,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉 🎉 🎉 🍾 🍾 🍾

Congratulations-Memes-FEATURED

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

I am leaving this comment here because you did not make any change in your Readme file for this milestone(PR), thus your `Readme file is not accessible for inline comments.

You consider:

  • [OPTIONAL] Updating the Getting started section of your readme file with explicit steps on how to clone and run your app locally as this will of help to non technical users.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants