Bump croaring to v2.1.2 #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CRoaring now requires atomic support (at least C11) which is a little bit finicky across all platforms to get the right flags through setuptools for both CRoaring and Cython generated C++. This commit splits out the CRoaring library into it's own section separate to the Python extension to enable this. Originally this was done for Windows as well, but that lead to linker errors on Windows ARM wheel builds...
3.12 is now officially released. Also change the strategy for the CIBW job to not fail-fast, so all platforms continue wheel building even if one of them fails.
SamHames
force-pushed
the
bump_croaring
branch
from
64567c1
to
ff09f02
Compare
I think that's not true because Visual Studio failed to provide atomic support with C11. And we support Visual Studio. However, we do require C11. |
|
Nice, good catch with this bug, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps croaring to the latest release amalgamation (v2.1.2, including bugfixes relating to shifts). This requires some changes in setup.py to get it to build correctly everywhere as the newer CRoaring versions now require atomic support.
Closes #104
Misc changes:
I've confirmed that this builds wheels for all platforms too.