fix: update graphics command

F-star · Jun 16, 2024 · 4b1eab7 · 4b1eab7
1 parent 665fbcb
commit 4b1eab7
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/packages/core/src/commands/update_graphics_attrs_cmd.ts b/packages/core/src/commands/update_graphics_attrs_cmd.ts
@@ -30,6 +30,9 @@ export class UpdateGraphicsAttrsCmd implements ICommand {
         console.warn(`graphics ${id} is lost.`);
         return;
       }
+      if (attrs.parentIndex) {
+        graphics.removeFromParent();
+      }
       graphics.updateAttrs(attrs);
       if (attrs.parentIndex) {
         graphics.insertAtParent(graphics.attrs.parentIndex!.position);
@@ -40,6 +43,7 @@ export class UpdateGraphicsAttrsCmd implements ICommand {
       const graphics = doc.getGraphicsById(id);
       if (graphics) {
         graphics.setDeleted(true);
+        graphics.removeFromParent();
       }
     }
 
@@ -66,6 +70,9 @@ export class UpdateGraphicsAttrsCmd implements ICommand {
         console.warn(`graphics ${id} is lost.`);
         return;
       }
+      if (attrs.parentIndex) {
+        graphics.removeFromParent();
+      }
       graphics.updateAttrs(attrs);
       if (attrs.parentIndex) {
         graphics.insertAtParent(graphics.attrs.parentIndex!.position);