Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output height drift #1

Merged
merged 1 commit into from
May 13, 2018
Merged

Fix output height drift #1

merged 1 commit into from
May 13, 2018

Conversation

kjin
Copy link
Contributor

@kjin kjin commented May 10, 2018

First of all -- thanks for the great module! It's really useful for showing colored terminal outputs in READMEs 馃槃

I noticed that as the number of lines increases, the height of the resulting SVG drifts (it seems like 1 pixel per line). For example, in this snippet:

const ats = require('ansi-to-svg');

console.log(ats(new Array(20).fill('.').join('\n')));

The last dot completely drops off the bottom of the SVG, resulting in only 19 dots.

I think this fix can address that. Please take a look!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 21

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.872%

Totals Coverage Status
Change from base Build 20: 0.0%
Covered Lines: 101
Relevant Lines: 101

馃挍 - Coveralls

@F1LT3R
Copy link
Owner

F1LT3R commented May 13, 2018

Fantastic work @kjin 馃憡 Thank you for this!

Sorry to take so long to get to this. It's been a busy week.

I'm just checking tests here and I'll push the latest version in a minute if all looks good.

@F1LT3R F1LT3R mentioned this pull request May 13, 2018
@F1LT3R F1LT3R merged commit b3022de into F1LT3R:master May 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants