Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easier way to scan the "RESTARTS" column #128

Closed
srid opened this issue Jan 14, 2024 · 8 comments
Closed

Easier way to scan the "RESTARTS" column #128

srid opened this issue Jan 14, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@srid
Copy link
Contributor

srid commented Jan 14, 2024

Feature Request

Make it easier to look for non-zero numbers in the RESTARTS column.

Use Case:

When you have 20 processes, and only one of them has restarted non-zero of times, I'd like to see which process that is by a quick scan.

Proposed Change:

Replace 0 with - (or even empty cell)

In this example, kafka has restarted 3 times (no other processes restarted) -- which had us file juspay/services-flake#72 -- but you have to more or less do a O(n) scan of the RESTARTs column to get to it. Can we visually make it easy to spot that?

image

Who Benefits From The Change(s)?

Everyone?

Alternative Approaches

None I can think of.

@F1bonacc1
Copy link
Owner

Hi @srid,
As an alternative, did you try sorting the processes by the restart count, SHIFT-R in this case?

@srid
Copy link
Contributor Author

srid commented Jan 15, 2024

That's a good alternative, though I'd say having a quick way to visually scan (without explicit user action) would be nice as well.

@F1bonacc1 F1bonacc1 added the enhancement New feature or request label Jan 20, 2024
@F1bonacc1
Copy link
Owner

Hi @srid,

I tried the proposed approach to show only positive restarts count.
The empty cell disagrees with my OCD and doesn't look well when there are no restarts at all:
image

If I use - it looks better:
image

I also tried to use the bold font style, at least in my terminal the difference is invisible...
Then I tried a slightly darker blue:
image

Which one do you think looks the best?
👍🏻 - First image.
🎉 - Second image.
🚀 - Third image.

@thenonameguy
Copy link
Sponsor Contributor

Probably use the same for exit code column (and maybe have the same for age/health) as well? Just to be consistent.

@srid
Copy link
Contributor Author

srid commented Jan 20, 2024

@F1bonacc1 Interesting.

I'd say the second image (using -) is better (I see there are already 3 votes for it.)

In regards to the third image, the color difference is not super obvious, so it looks more or less like the first image

@srid
Copy link
Contributor Author

srid commented Jan 20, 2024

Probably use the same for exit code column (and maybe have the same for age/health) as well? Just to be consistent.

I also noticed how the exit code column shows 0 for processes that are still running. How can a running process have a exit code (here, 0) when it has not exited?

EDIT: Perhaps - should be used for have-not-exited processes? Just like - is being proposed to be used for have-not-restarted processes.

@F1bonacc1
Copy link
Owner

Will be part of the next release.

@F1bonacc1
Copy link
Owner

Added in v0.81.4
Please let me know if it works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants