Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new Streamlit version #1

Closed
F1nnM opened this issue Sep 25, 2021 · 9 comments
Closed

Update to new Streamlit version #1

F1nnM opened this issue Sep 25, 2021 · 9 comments
Assignees
Labels

Comments

@F1nnM
Copy link
Owner

F1nnM commented Sep 25, 2021

No description provided.

@sreyan-ghosh
Copy link
Contributor

Hi @F1nnM, I would like to work on this issue. It would be great if you could assign it to me.
I would like this to be a part of my Hacktoberfest PRs so is it okay if I submit the PR on 1st Oct?

Also, there are 2 ways in which I would approach this:

  • Simply change the latest version value in requirements.txt
+streamlit==0.89.0
-streamlit==0.80.0
hiplot==0.1.23
pandas==1.2.3
  • Make it more robust for all packages in the requirements.txt file:

    • change in Dockerfile and requirements.txt
FROM python:3.8

WORKDIR /app

ADD requirements.txt /app/requirements.txt
+RUN pip install -r requirements.txt --upgrade
-RUN pip install -r requirements.txt

ADD . /app/
+streamlit>=0.80.0
+hiplot>=0.1.23
+pandas>=1.2.3
+shap>=0.38.1
+xgboost>=1.3.3
+matplotlib>=3.3.4
+numpy>=1.20.1
-streamlit==0.80.0
-hiplot==0.1.23
-pandas==1.2.3
-shap==0.38.1
-xgboost==1.3.3
-matplotlib==3.3.4
-numpy==1.20.1

Do let me know if you would prefer the second method over the first or if there is something that can go wrong. Cheers.

@F1nnM
Copy link
Owner Author

F1nnM commented Sep 25, 2021

Oh hi, thank you!
I'm afraid there is an issue with the second option: Breaking changes in updates. One day it works, the other it doesn't because their was an update that changed the API. I think Streamlit is especially prone to that, as it is still under heavy development.

Also, please check whether the update already breaks something. I think Streamlit might have moved some beta-features I used out of beta, so the method-name of some things might have changed. It shouldn't be to difficult to fix though.

@sreyan-ghosh
Copy link
Contributor

Okay @F1nnM, I changed back and set the version of streamlit to 0.89.0. I also went through the changelog for some affecting changes and saw that none were causing any issues. I'll submit the PR on the 1st of October. Is that ok?

@F1nnM
Copy link
Owner Author

F1nnM commented Sep 25, 2021

I just checked myself, and the the layouting options where moved out of beta. So all the st.beta_columns become st.columns.
I think that's it though.
Once that's changed and the app still works, sure, submit your request.

@F1nnM
Copy link
Owner Author

F1nnM commented Sep 25, 2021

Oh, and I'm curious.. How did you find my project? I didn't think anyone would actually find these, yet, here you are, just two hours after I created the issues.

@sreyan-ghosh
Copy link
Contributor

I couldn't find where you used st.beta_columns, I looked in all of the .py files. Could you direct me to where the changes need to be done?

Oh, I went into issues and filtered using the open issues that use python and have labels hacktoberfest or good-first-issue. That narrows it down a lot and since it is sorted as per the latest activity, your repo popped up.

@F1nnM
Copy link
Owner Author

F1nnM commented Sep 25, 2021

Oh, I'm sorry, I was sure I used the columns. Apparently I didn't. But the beta_expander is also not in the beta anymore, if I remember correctly.
If I'm wrong again, that get's really embarrasing..

@sreyan-ghosh
Copy link
Contributor

Yes, you are right, st.beta_expander has been moved out of beta, but the support for beta_expander is still there. It's better if we change it of course. I'll add that to my PR. 👍

@F1nnM
Copy link
Owner Author

F1nnM commented Sep 26, 2021

Thank you! I think that's it!
Once hacktoberfest starts, you can submit the PR and I'll accept it, as soon as I get to it.

F1nnM added a commit that referenced this issue Oct 1, 2021
@F1nnM F1nnM closed this as completed Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants