Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed logstf plugin not creating folder if it doesn't exist #25

Closed
wants to merge 1 commit into from
Closed

Fixed logstf plugin not creating folder if it doesn't exist #25

wants to merge 1 commit into from

Conversation

TheBv
Copy link
Contributor

@TheBv TheBv commented Apr 30, 2023

Fixes #23

F2
F2 requested changes Apr 30, 2023
View reviewed changes
Copy link
Owner

@F2 F2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. :)

It makes sense to put it in GetLogPath().
However, it doesn't work with multiple levels of directories... e.g. sv_logsdir my/path/to/logs

@TheBv
Copy link
Contributor Author

TheBv commented Apr 30, 2023

Fixed :)

@F2
Copy link
Owner

F2 commented Apr 30, 2023

Awesome, thanks. I am going to include this in my next logstf release in #24.

@F2 F2 closed this Apr 30, 2023
@sapphonie sapphonie mentioned this pull request Oct 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@F2 F2 F2 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

logs.tf plugin does not check for the 'logs' folder before writing to log file
2 participants
@TheBv @F2