Feature.add ability to redraft a traffic policy #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
drafting on a non-draft box is a harmless operation. and we dont raise errors anywhere else in the policy classes about it not being supported This method was modeled after the publish() method. there is no _publish for it |
|
i have not merged that PR that introduced publish and if i had been reviewing this i would say the same thing. and for the error we should raise either exception or a warning |
caphrim007
force-pushed
the
feature.add-ability-to-redraft-a-traffic-policy
branch
from
f586e7b
to
230f57f
Compare
|
i think you missed import statement :) |
|
btw i am ok without wrapping the method you convinced me :) |
caphrim007
force-pushed
the
feature.add-ability-to-redraft-a-traffic-policy
branch
2 times, most recently
from
ef170aa
to
d866077
Compare
Issues: Fixes F5Networks#1098 Problem: Policies cannot be successfully re-drafted for editing and re-publishing. Analysis: This patch adds a `draft` method that allows you to put the policy into a draft state from where you can then edit it. Tests: functional
caphrim007
force-pushed
the
feature.add-ability-to-redraft-a-traffic-policy
branch
from
d866077
to
37f8fb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to re-draft a traffic policy
Issues:
Fixes #1098
Problem:
Policies cannot be successfully re-drafted for editing and re-publishing.
Analysis:
This patch adds a
draftmethod that allows you to put the policy intoa draft state from where you can then edit it.
Tests:
functional