_validate_suffix_collections needs rework

[wojtek0806]

I have recently hit an edge case where the name of my resource had to contain '/' this has led to problems with our validation method:

C:\Users\wypior\Documents\PythonProjects\f5-common-python\f5\bigip\tm\gtm\test\functional\test_topology.py:57: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
C:\Users\wypior\Documents\PythonProjects\f5-common-python\f5\bigip\tm\gtm\test\functional\test_topology.py:47: in delete_topology
    name=name)
C:\Users\wypior\Documents\PythonProjects\f5-common-python\f5\bigip\tm\gtm\topology.py:145: in load
    return self._load(**kwargs)
C:\Users\wypior\Documents\PythonProjects\f5-common-python\f5\bigip\resource.py:919: in _load
    response = refresh_session.get(base_uri, **kwargs)
C:\Python27\Lib\site-packages\icontrol\session.py:221: in wrapper
    sub_path, suffix, **kwargs)
C:\Python27\Lib\site-packages\icontrol\session.py:177: in generate_bigip_uri
    _validate_uri_parts(base_uri, partition, name, sub_path, suffix)
C:\Python27\Lib\site-packages\icontrol\session.py:151: in _validate_uri_parts
    _validate_name_partition_subpath(name)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

element = 'ldns: subnet 192.168.100.0/24 server: subnet 192.168.200.0/24'

    def _validate_name_partition_subpath(element):
        # '/' and '~' are illegal characters
        if element == '':
            return True
        if '~' in element:
            error_message =\
                "instance names and partitions cannot contain '~', but it's: %s"\
                % element
            raise InvalidInstanceNameOrFolder(error_message)
        elif '/' in element:
            error_message =\
                "instance names and partitions cannot contain '/', but it's: %s"\
                % element
>           raise InvalidInstanceNameOrFolder(error_message)
E           InvalidInstanceNameOrFolder: instance names and partitions cannot contain '/', but it's: ldns: subnet 192.168.100.0/24 server: subnet 192.168.200.0/24

C:\Python27\Lib\site-packages\icontrol\session.py:123: InvalidInstanceNameOrFolder

This issue is blocking the implementation of GTM endpoints in our SDK

[wojtek0806]

@swormke

[wojtek0806]

the self link for this resource looks like this:

u'https://localhost/mgmt/tm/gtm/topology/ldns:%20subnet%20192.168.100.0~24%20server:%20subnet%20192.168.200.0~24?ver=12.1.0'

[caphrim007]

@wojtek0806 slashes arent the problem as the selfLink shows that slashes are converted, or interpreted, as tilde's (~).

What happens if you provide your same value with ~ instead of / ?

[wojtek0806]

if you check function it will also raise exception..