Adds support for bigiq tokens that have different fields #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pjbreaux this needs to go in asap to support bigiq. |
Issues: Fixes F5Networks#127 Problem: The bigiq tokens do not include an expiration micros field so it needs to be calculated from the last-update micros Analysis: This patch adds those changes and refactors the methods to be smaller and more easily tested. Tests:
caphrim007
force-pushed
the
feature.support-bigiq-token-expiration
branch
from
0751c0b
to
fff68f3
Compare
|
and gruber needs this patch for a thing he's working on for openstack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Fixes #127
Problem:
The bigiq tokens do not include an expiration micros field so it
needs to be calculated from the last-update micros
Analysis:
This patch adds those changes and refactors the methods to be
smaller and more easily tested.
Tests: