Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance as3 response add the runtime attribute #3232

Closed
kylinsoong opened this issue Jan 15, 2024 · 8 comments
Closed

Enhance as3 response add the runtime attribute #3232

kylinsoong opened this issue Jan 15, 2024 · 8 comments

Comments

@kylinsoong
Copy link

The AS3 Post's success response contains a runtime attribute which hints how long the AS3 post executed on AS3 service,

	{
	  "results": [
	    {
	      "code": 200,
	      "message": "success",
	      "lineCount": 30,
	      "host": "localhost",
	      "tenant": "cistest001",
	      "runTime": 1764
	    }
	  ],

Currently we only log code, message and tenant,

2024/01/15 05:13:12 [DEBUG] [AS3] Response from BIG-IP: code: 200 --- tenant:cistest003 --- message: success

Can we add the runTime to the log?

The other 2 inquery:

  1. Can use use comma to replace 3 short striping? this will more friendly for fluentd based cloud native logging mechanism?
  2. Can adjust the log level from DEBUG to INFO? since we use --log-as3-response=true to contain the AS3 respone?
@trinaths
Copy link
Contributor

Why do we need to add runtime in as3 response ? What is the actual ask ? Why do we need to adjust log level from DEBUG to INFO - Not clear on the ask ?

@trinaths trinaths added awaiting response Awaiting response and removed untriaged no JIRA created labels Jan 16, 2024
@kylinsoong
Copy link
Author

Why do we need to add runtime in as3 response ? What is the actual ask ? Why do we need to adjust log level from DEBUG to INFO - Not clear on the ask ?

  • The runtime is a hint for how long the AS3 is execution the POST request, if CIS log contains this can help to analysis the CIS sync performance issue

  • I am assisting a customer to analysis a performance issue in production, CIS in Hub mode, Configmap has more than 30 Namespaces, in one namespace there has around 200 services, the issue is, add new app to current configmap, or any endpoint change to sync to VE need around 2 minutes, customer has enable --log-as3-response=true but no any log util change the log level from INFO to DEBUG, so I wonder whether we can force the AS3 response be logged is customer has set --log-as3-response=true

@trinaths
Copy link
Contributor

@kylinsoong Recommend customer to use multiple partitions and relevant to namespaces for improved performance.

@charanm08
Copy link
Contributor

charanm08 commented Jan 17, 2024

Created JIRA CONTCNTR-4398 for internal PM tracking.

@trinaths trinaths added JIRA and removed awaiting response Awaiting response labels Jan 17, 2024
vidyasagar-m added a commit to vidyasagar-m/k8s-bigip-ctlr that referenced this issue Jan 22, 2024
vidyasagar-m added a commit to vidyasagar-m/k8s-bigip-ctlr that referenced this issue Jan 23, 2024
vidyasagar-m added a commit to vidyasagar-m/k8s-bigip-ctlr that referenced this issue Jan 29, 2024
vidyasagar-m added a commit to vidyasagar-m/k8s-bigip-ctlr that referenced this issue Jan 29, 2024
vidyasagar-m added a commit to vidyasagar-m/k8s-bigip-ctlr that referenced this issue Jan 29, 2024
@vidyasagar-m
Copy link
Contributor

Hi @kylinsoong, could you test the above with this build image vidyasagar0416/k8s-bigip-ctlr:latest and confirm.

@kylinsoong
Copy link
Author

@vidyasagar-m

I am not saw any behavior change, use both vidyasagar0416/k8s-bigip-ctlr:latest and quay.io/f5networks/k8s-bigip-ctlr-devel:60396254051aa8ffaf18f882f384ca146d2de42d, the configuration of CIS looks

          args: [
            "--bigip-username=$(BIGIP_USERNAME)",
            "--bigip-password=$(BIGIP_PASSWORD)",
            "--cccl-log-level=INFO",
            "--log-level=INFO",
            "--manage-ingress=false",
            "--node-poll-interval=600",
            "--periodic-sync-interval=36000",
            "--manage-configmaps=true",
            "--bigip-url=10.1.10.240",
            "--insecure=true",
            "--hubmode=true",
            "--filter-tenants=true",
            "--log-as3-response=true",
            "--bigip-partition=k8s",
            "--pool-member-type=cluster",
            "--namespace=f5-hub-1",
            "--namespace=f5-hub-2"
            ]

Also vidyasagar0416/k8s-bigip-ctlr:latest keep crash with a time interval with the log

2024/01/31 03:38:38 [INFO] [INIT] Exiting - signal terminated

@trinaths
Copy link
Contributor

trinaths commented Feb 1, 2024

@kylinsoong Please share POD crash logs to further investigate this issue.

@trinaths
Copy link
Contributor

Closed as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants