Skip to content

Commit

Permalink
FFWEB-1007 : Remove 'keep-filter' parameter from module configuration
Browse files Browse the repository at this point in the history
  • Loading branch information
a-laurowski authored and a.laurowski committed Jan 9, 2019
1 parent 15e493a commit 431ac5b
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 19 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
- Add missing title to `factfinder_result_index` site
- Exclude FACT-Finder Web Components js script from minification

## CHANGE
- Remove 'keep-filters' parameter from module configuration

#ADD
- Added possibility to export additional attributes in separate columns
- Adds possibility to configure frequency of feed file generation by Cron
Expand Down
5 changes: 0 additions & 5 deletions Omikron/Factfinder/Block/FF/Communication.php
Original file line number Diff line number Diff line change
Expand Up @@ -104,11 +104,6 @@ public function __construct(
'type' => 'string',
'defaultValue' => $defaultValues['advanced']['add_tracking_params']
],
'keep-filters' => [
'value' => $this->_helper->getKeepFilters(),
'type' => 'boolean',
'defaultValue' => $defaultValues['advanced']['keep_filters']
],
'keep-url-params' => [
'value' => $this->_helper->getKeepUrlParams(),
'type' => 'string',
Expand Down
9 changes: 0 additions & 9 deletions Omikron/Factfinder/Helper/Data.php
Original file line number Diff line number Diff line change
Expand Up @@ -243,15 +243,6 @@ public function getAddTrackingParams()
return $this->scopeConfig->getValue('factfinder/advanced/add_tracking_params', 'store');
}

/**
* Returns the keep-filters configuration
* @return mixed
*/
public function getKeepFilters()
{
return $this->scopeConfig->getValue('factfinder/advanced/keep_filters', 'store');
}

/**
* Returns the keep-url-params configuration
* @return mixed
Expand Down
5 changes: 0 additions & 5 deletions Omikron/Factfinder/etc/adminhtml/system.xml
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,6 @@
<label>add-tracking-params</label>
<comment>With this property you can deliver standard parameters which are attached to every tracking request. Example: param1=abc,param2=xyz.</comment>
</field>
<field id="keep_filters" translate="label" type="select" sortOrder="80" showInDefault="1" showInWebsite="1" showInStore="1">
<label>keep-filters</label>
<source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
<comment>With this property you can determine if filters (which where set before the search, e.g. via ASN) should be kept or discarded.</comment>
</field>
<field id="keep_url_params" translate="label" type="text" sortOrder="90" showInDefault="1" showInWebsite="1" showInStore="1">
<label>keep-url-params</label>
<comment>Determines if parameters which are written into the URL should be kept.</comment>
Expand Down

0 comments on commit 431ac5b

Please sign in to comment.