Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move factfinder.communication to after.body.start #82

Merged
merged 1 commit into from
Dec 17, 2018

Conversation

fritzmg
Copy link
Contributor

@fritzmg fritzmg commented Dec 14, 2018

The header.panel container might not be available in all themes, thus the important <ff-communication> block might not be inserted into the layout. The after.body.start position will always be present (as far as I know). There is no reason for the <ff-communication> element to be inside any actual DOM element. It should be one of the first elements on the page.

@a-laurowski a-laurowski merged commit aeef42f into FACT-Finder-Web-Components:develop Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants