Add advanced login parameters #1096
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also slightly changes how the login widget behaves. The client will not connect to the server until the user clicks 'log in'
Gatsik
added a commit
to Gatsik/client
that referenced
this pull request
Jun 24, 2021
* See FAForever#1096 * This changes chat's initial port and enables ssl by default Signed-off-by: gatsik <74517072+Gatsik@users.noreply.github.com>
Closed
Gatsik
added a commit
that referenced
this pull request
Aug 8, 2021
* See #1096 * This changes chat's initial port and enables ssl by default Signed-off-by: gatsik <74517072+Gatsik@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier for developers/testers to connect to the test system, although this might not be relevant for a whole lot longer.
Adding the LoginWidget as a child of the main window changed it's style so I messed with the client.css a little bit to make the default style a little more generic/consistent.
The advanced options are only shown when you toggle them with the "Advanced" button.