Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make util get its APPDATA_DIR from Settings #666

Merged
merged 2 commits into from Mar 19, 2017

Conversation

Wesmania
Copy link
Contributor

@Wesmania Wesmania commented Mar 16, 2017

Instead of setting it independently in copypasta code.

Signed-off-by: Igor Kotrasinski ikotrasinsk@gmail.com

  • PR branch should be named issuenum-fix/feature/cleanup-description
  • Code is split into logical commits
  • Code has tests
  • Final commit includes "Fixes #issue" in commit message

When all builds pass and a maintainer is happy with your PR, the "ready" label will be applied. Please complete these tasks then:

  • Rebase onto develop
  • Add changelog entry
  • Remove this entire template section

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 21.609% when pulling c103cf0 on Wesmania:665-fix-util-appdata-dir into 9539e6b on FAForever:develop.

@Wesmania Wesmania added this to the 0.12.x milestone Mar 19, 2017
Instead of setting it independently in copypasta code.

Signed-off-by: Igor Kotrasinski <ikotrasinsk@gmail.com>
Fixes FAForever#665.

Signed-off-by: Igor Kotrasinski <ikotrasinsk@gmail.com>
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 22.181% when pulling 17fc49d on Wesmania:665-fix-util-appdata-dir into 91e234e on FAForever:develop.

@duk3luk3 duk3luk3 merged commit 17fc49d into FAForever:develop Mar 19, 2017
@Wesmania Wesmania deleted the 665-fix-util-appdata-dir branch May 22, 2017 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants