Skip to content

Commit

Permalink
Remove unused ReadyPartyMessage / UnreadyPartyMessage
Browse files Browse the repository at this point in the history
  • Loading branch information
Katharsas committed Aug 21, 2021
1 parent b73260f commit 774cf79
Show file tree
Hide file tree
Showing 9 changed files with 0 additions and 76 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,6 @@ public interface FafServerAccessor {

void kickPlayerFromParty(Player kickedPlayer);

void readyParty();

void unreadyParty();

void leaveParty();

void setPartyFactions(List<Faction> factions);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,11 @@
import com.faforever.client.remote.domain.outbound.faf.MatchmakerInfoOutboundMessage;
import com.faforever.client.remote.domain.outbound.faf.PingMessage;
import com.faforever.client.remote.domain.outbound.faf.PongMessage;
import com.faforever.client.remote.domain.outbound.faf.ReadyPartyMessage;
import com.faforever.client.remote.domain.outbound.faf.RemoveFoeMessage;
import com.faforever.client.remote.domain.outbound.faf.RemoveFriendMessage;
import com.faforever.client.remote.domain.outbound.faf.RestoreGameSessionMessage;
import com.faforever.client.remote.domain.outbound.faf.SelectAvatarMessage;
import com.faforever.client.remote.domain.outbound.faf.SetPartyFactionsMessage;
import com.faforever.client.remote.domain.outbound.faf.UnreadyPartyMessage;
import com.faforever.client.remote.domain.outbound.gpg.GpgOutboundMessage;
import com.faforever.client.reporting.ReportingService;
import com.faforever.client.serialization.FactionMixin;
Expand Down Expand Up @@ -579,16 +577,6 @@ public void kickPlayerFromParty(Player kickedPlayer) {
writeToServer(new KickPlayerFromPartyMessage(kickedPlayer.getId()));
}

@Override
public void readyParty() {
writeToServer(new ReadyPartyMessage());
}

@Override
public void unreadyParty() {
writeToServer(new UnreadyPartyMessage());
}

@Override
public void leaveParty() {
writeToServer(new LeavePartyMessage());
Expand Down
8 changes: 0 additions & 8 deletions src/main/java/com/faforever/client/remote/FafService.java
Original file line number Diff line number Diff line change
Expand Up @@ -583,14 +583,6 @@ public void leaveParty() {
fafServerAccessor.leaveParty();
}

public void readyParty() {
fafServerAccessor.readyParty();
}

public void unreadyParty() {
fafServerAccessor.unreadyParty();
}

public void setPartyFactions(List<Faction> factions) {
fafServerAccessor.setPartyFactions(factions);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -321,16 +321,6 @@ public void kickPlayerFromParty(com.faforever.client.player.Player kickedPlayer)

}

@Override
public void readyParty() {

}

@Override
public void unreadyParty() {

}

@Override
public void leaveParty() {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,12 @@
import com.faforever.client.remote.domain.outbound.faf.MatchmakerInfoOutboundMessage;
import com.faforever.client.remote.domain.outbound.faf.PingMessage;
import com.faforever.client.remote.domain.outbound.faf.PongMessage;
import com.faforever.client.remote.domain.outbound.faf.ReadyPartyMessage;
import com.faforever.client.remote.domain.outbound.faf.RemoveFoeMessage;
import com.faforever.client.remote.domain.outbound.faf.RemoveFriendMessage;
import com.faforever.client.remote.domain.outbound.faf.RemoveSocialMessage;
import com.faforever.client.remote.domain.outbound.faf.RestoreGameSessionMessage;
import com.faforever.client.remote.domain.outbound.faf.SelectAvatarMessage;
import com.faforever.client.remote.domain.outbound.faf.SetPartyFactionsMessage;
import com.faforever.client.remote.domain.outbound.faf.UnreadyPartyMessage;
import com.faforever.client.remote.domain.outbound.gpg.AIOptionMessage;
import com.faforever.client.remote.domain.outbound.gpg.ChatMessage;
import com.faforever.client.remote.domain.outbound.gpg.ClearSlotMessage;
Expand Down Expand Up @@ -91,8 +89,6 @@
@Type(value = AcceptPartyInviteMessage.class, name = AcceptPartyInviteMessage.COMMAND),
@Type(value = KickPlayerFromPartyMessage.class, name = KickPlayerFromPartyMessage.COMMAND),
@Type(value = LeavePartyMessage.class, name = LeavePartyMessage.COMMAND),
@Type(value = ReadyPartyMessage.class, name = ReadyPartyMessage.COMMAND),
@Type(value = UnreadyPartyMessage.class, name = UnreadyPartyMessage.COMMAND),
@Type(value = SetPartyFactionsMessage.class, name = SetPartyFactionsMessage.COMMAND),
@Type(value = GameMatchmakingMessage.class, name = GameMatchmakingMessage.COMMAND),
@Type(value = MatchmakerInfoOutboundMessage.class, name = MatchmakerInfoOutboundMessage.COMMAND),
Expand Down

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -348,14 +348,6 @@ private void initializeParty() {
}
}

public void readyParty() {
fafService.readyParty();
}

public void unreadyParty() {
fafService.unreadyParty();
}

public void sendFactionSelection(List<Faction> factions) {
fafService.setPartyFactions(factions);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -579,20 +579,6 @@ public void testPlayerReadyForMatch() {
assertMessageContainsComponents("match_ready");
}

@Test
public void testReadyParty() {
instance.readyParty();

assertMessageContainsComponents("ready_party");
}

@Test
public void testUnreadyParty() {
instance.unreadyParty();

assertMessageContainsComponents("unready_party");
}

@Test
public void testLeaveParty() {
instance.leaveParty();
Expand Down

0 comments on commit 774cf79

Please sign in to comment.