Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Play" Tab: Game info view not being updated when lobby closed #1161

Closed
ArXen42 opened this issue Apr 22, 2019 · 2 comments
Closed

"Play" Tab: Game info view not being updated when lobby closed #1161

ArXen42 opened this issue Apr 22, 2019 · 2 comments
Labels

Comments

@ArXen42
Copy link

ArXen42 commented Apr 22, 2019

The problem seems to be something like missing "lobby closed" event handling. Maybe it's intended behaviour though, not sure.

  1. Create some lobby.
  2. Click on it in FAF client, so that lobby info info would be shown at the right side.
  3. Abandon the game (or launch it), lobby should disappear from the list of games.
  4. Despite lobby no longer being in the list, it's info would still be shown at the right side.

Example: game "800 1500" displayed at the right side was already finished when the screenshot was taken:
image

@micheljung micheljung added the bug label Apr 24, 2019
@micheljung
Copy link
Member

Yes we should remove it when the game is no longer in the list.

1-alex98 pushed a commit that referenced this issue Apr 26, 2019
I fixed the client not updating game correctly
Fixes #1161
@1-alex98 1-alex98 mentioned this issue Apr 26, 2019
@1-alex98
Copy link
Member

No wait that is not fixed by this ups

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants