Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show years in player rating history #1220

Closed
Geosearchef opened this issue May 7, 2019 · 2 comments · Fixed by #1871
Closed

Show years in player rating history #1220

Geosearchef opened this issue May 7, 2019 · 2 comments · Fixed by #1871
Milestone
v1.2.1

Comments

@Geosearchef
Copy link
Member

The player rating history shows dates below the graph which can get pretty useless if the history spans multiple years.
@Androish
Copy link

Androish commented May 9, 2019

I would like to add that right now X is not a function of time, but a function of number of games. This is partly why it looks this strange.

While that is ok I guess, I would much rather prefer it being a function of time, or atleast have the option of doing it that way.

I want to see my rating being a straight line if I am not playing any games :D

@Androish
Copy link

This is basically the same as #935

@Sheikah45 Sheikah45 mentioned this issue Aug 29, 2020
Merged
1-alex98 added a commit that referenced this issue Sep 17, 2020
@Sheikah45 @1-alex98
Add proper time filtering to rating graph and display year
5bfe39f 
Fixes #935
Fixes #1220

Co-authored-by: axel1200 <alexander.von.trostorff@gmail.com>
@micheljung micheljung added this to the v1.2.1 milestone Sep 24, 2020
mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this issue Apr 15, 2022
@Sheikah45 @1-alex98
Add proper time filtering to rating graph and display year
5f1856f 
Fixes FAForever#935
Fixes FAForever#1220

Co-authored-by: axel1200 <alexander.von.trostorff@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2.1
Development

Successfully merging a pull request may close this issue.

Add proper time filtering to rating graph Sheikah45/downlords-faf-client
3 participants
@micheljung @Geosearchef @Androish