Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop out tabs? #133

Closed
Cheyans opened this issue Dec 3, 2015 · 8 comments
Closed

Pop out tabs? #133

Cheyans opened this issue Dec 3, 2015 · 8 comments

Comments

@Cheyans
Copy link
Contributor

Cheyans commented Dec 3, 2015

Not sure if this is a good thing or not, but someone requested the ability to see chat and games at the same time. Maybe a more functional way of doing this is by allowing people to pop out tabs so they can view any tabs at the same time


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@Cheyans Cheyans added the Task label Dec 3, 2015
@1-alex98 1-alex98 self-assigned this Jun 11, 2017
@1-alex98
Copy link
Member

image
crazy shit no?

1-alex98 added a commit that referenced this issue Jun 11, 2017
Fixes #133
needs further improvment
1-alex98 added a commit that referenced this issue Jun 12, 2017
Fixes #133
needs further improvment
1-alex98 added a commit that referenced this issue Jun 12, 2017
Fixes #133
needs further improvment
1-alex98 pushed a commit that referenced this issue Jun 13, 2017
Fixes #532
Fixes #133
needs further improvment
1-alex98 added a commit that referenced this issue Jun 13, 2017
…eature/#133-pop-out-tab

# Conflicts:
#	src/main/java/com/faforever/client/chat/ChatController.java
1-alex98 added a commit that referenced this issue Jun 13, 2017
…eature/#133-pop-out-tab

# Conflicts:
#	src/main/java/com/faforever/client/chat/ChatController.java
1-alex98 added a commit that referenced this issue Jun 13, 2017
1-alex98 added a commit that referenced this issue Jun 13, 2017
@micheljung
Copy link
Member

Lovely! Can they be "popped back in"?

@1-alex98
Copy link
Member

You can by closing the Window... I thought about which button or how to popp them back in and i think it is most intuitive to use the close button. I might also enable dragging them back though :#

@micheljung
Copy link
Member

See also:
https://www.youtube.com/watch?v=q_n23Ah1ftQ

This would fix #256 as well? But we had to make it look less ugly :)

@micheljung
Copy link
Member

micheljung commented Jun 23, 2017

Or https://www.youtube.com/watch?time_continue=21&v=ALYtkXrzHDI

Btw. I'm not sure whether it's intuitive that closing a window pops a tab back in. I know Google is doing it with Hangouts/Gmail but it still feels weird to me. Browsers to not behave that way, if you close a window, tabs are gone (but ofc. there is no "main" window in browsers)

@micheljung
Copy link
Member

micheljung commented Jun 23, 2017

For the record, this feature has been requested 5 years ago and has most recently be targeted to Java 10 - so not gonna happen in the next few years.

@1-alex98
Copy link
Member

1-alex98 commented Jun 23, 2017

You could drag them back in. I don' know what to think about this pilot projects on YouTube I rather do it my self, because you need to set the themes etc. to the tabs and also wanna use the window controller implemented in the client. And they are all not fully developed libaries as it seems to be 😬.Further I don't now if having Tabs outside the tabPane in the main Application is of any sense. I will defenitely mange to let the tabs change position and maybe I can simply invent some new Button to pop them back in 🤔

@1-alex98 1-alex98 removed their assignment Oct 1, 2017
@1-alex98
Copy link
Member

Well not really planned and I wanna clean up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants