Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove player selection when selecting live replay #1375

Closed
Wesmania opened this issue Jul 31, 2019 · 0 comments · Fixed by #1530
Closed

Remove player selection when selecting live replay #1375

Wesmania opened this issue Jul 31, 2019 · 0 comments · Fixed by #1530
Labels
enhancement Hacktoberfest S2 major severity 2 - major - major loss of function
Projects
Hacktoberfest 2019

Comments

@Wesmania
Copy link
Collaborator

With the new replay server, player selection does not matter - any choice will get you the same merged replay. The UI bit can be removed, and you can replace player name with any nonempty string when accessing the replay.
@1-alex98 1-alex98 added S2 major severity 2 - major - major loss of function enhancement labels Aug 29, 2019
@Brutus5000 Brutus5000 added this to Replay topics in Hacktoberfest 2019 Sep 26, 2019
Wesmania pushed a commit to Wesmania/downlords-faf-client that referenced this issue Dec 17, 2019
Remove player choice from live replay button
5b40c2c 
Current live replay server merges all incoming streams into one,
therefore there's no need to select a specific player when launching a
live replay. Remove the selection from the UI, but still pick and send
some player's name in case the replay server finds it useful.

Fixes FAForever#1375.

Signed-off-by: Igor Kotrasinski <i.kotrasinsk@gmail.com>
Wesmania pushed a commit to Wesmania/downlords-faf-client that referenced this issue Dec 17, 2019
Remove player choice from live replay button
2159368 
Current live replay server merges all incoming streams into one,
therefore there's no need to select a specific player when launching a
live replay. Remove the selection from the UI, but still pick and send
some player's name in case the replay server finds it useful.

Fixes FAForever#1375.

Signed-off-by: Igor Kotrasinski <i.kotrasinsk@gmail.com>
Wesmania pushed a commit to Wesmania/downlords-faf-client that referenced this issue Dec 17, 2019
Remove player choice from live replay button
c632263 
Current live replay server merges all incoming streams into one,
therefore there's no need to select a specific player when launching a
live replay. Remove the selection from the UI, but still pick and send
some player's name in case the replay server finds it useful.

Fixes FAForever#1375.

Signed-off-by: Igor Kotrasinski <i.kotrasinsk@gmail.com>
Wesmania pushed a commit to Wesmania/downlords-faf-client that referenced this issue Dec 17, 2019
Remove player choice from live replay button
de8ea70 
Current live replay server merges all incoming streams into one,
therefore there's no need to select a specific player when launching a
live replay. Remove the selection from the UI, but still pick and send
some player's name in case the replay server finds it useful.

Fixes FAForever#1375.

Signed-off-by: Igor Kotrasinski <i.kotrasinsk@gmail.com>
Wesmania pushed a commit to Wesmania/downlords-faf-client that referenced this issue Dec 17, 2019
Remove player choice from live replay button
2ebdc29 
Current live replay server merges all incoming streams into one,
therefore there's no need to select a specific player when launching a
live replay. Remove the selection from the UI, but still pick and send
some player's name in case the replay server finds it useful.

Fixes FAForever#1375.

Signed-off-by: Igor Kotrasinski <i.kotrasinsk@gmail.com>
@Wesmania Wesmania mentioned this issue Dec 17, 2019
Merged
Wesmania pushed a commit to Wesmania/downlords-faf-client that referenced this issue Dec 17, 2019
Remove player choice from live replay button
deaba26 
Current live replay server merges all incoming streams into one,
therefore there's no need to select a specific player when launching a
live replay. Remove the selection from the UI, but still pick and send
some player's name in case the replay server finds it useful.

Fixes FAForever#1375.

Signed-off-by: Igor Kotrasinski <i.kotrasinsk@gmail.com>
Wesmania pushed a commit to Wesmania/downlords-faf-client that referenced this issue Dec 17, 2019
Remove player choice from live replay button
983d616 
Current live replay server merges all incoming streams into one,
therefore there's no need to select a specific player when launching a
live replay. Remove the selection from the UI, but still pick and send
some player's name in case the replay server finds it useful.

Fixes FAForever#1375.

Signed-off-by: Igor Kotrasinski <i.kotrasinsk@gmail.com>
Wesmania pushed a commit to Wesmania/downlords-faf-client that referenced this issue Dec 18, 2019
Remove player choice from live replay button
044d97e 
Current live replay server merges all incoming streams into one,
therefore there's no need to select a specific player when launching a
live replay. Remove the selection from the UI, but still pick and send
some player's name in case the replay server finds it useful.

Fixes FAForever#1375.

Signed-off-by: Igor Kotrasinski <i.kotrasinsk@gmail.com>
1-alex98 pushed a commit that referenced this issue Jan 1, 2020
@Wesmania @1-alex98
Remove player choice from live replay button (#1530)
8cf8fd9 
Remove player choice from live replay button

Current live replay server merges all incoming streams into one,
therefore there's no need to select a specific player when launching a
live replay. Remove the selection from the UI, but still pick and send
some player's name in case the replay server finds it useful.

Fixes #1375.
mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this issue Apr 15, 2022
@Wesmania
Remove player choice from live replay button (FAForever#1530)
39ba87f 
Remove player choice from live replay button

Current live replay server merges all incoming streams into one,
therefore there's no need to select a specific player when launching a
live replay. Remove the selection from the UI, but still pick and send
some player's name in case the replay server finds it useful.

Fixes FAForever#1375.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Hacktoberfest S2 major severity 2 - major - major loss of function
Projects
No open projects
Hacktoberfest 2019
Replay topics
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove player choice from live replay button Wesmania/downlords-faf-client
3 participants
@Wesmania @Brutus5000 @1-alex98