Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad encoding in replay more information #1395

Closed
norraxx opened this issue Aug 18, 2019 · 5 comments
Closed

Bad encoding in replay more information #1395

norraxx opened this issue Aug 18, 2019 · 5 comments
Labels

Comments

@norraxx
Copy link
Collaborator

norraxx commented Aug 18, 2019

bad_encoding

That unreadable code should be russian.

http://content.faforever.com/faf/vault/replay_vault/replay.php?id=10084790

@Brutus5000
Copy link
Member

But what is the right encoding?

@norraxx
Copy link
Collaborator Author

norraxx commented Aug 25, 2019

I think it should be utf8, if it's not, we have to solve it somehow.

@Askaholic
Copy link
Collaborator

Askaholic commented Aug 26, 2019

Yes that would be what's called Mojibake.

If it's Russian and it isn't UTF8 then I would guess windows-1251: https://en.wikipedia.org/wiki/Windows-1251

I don't think I would call this issue "beginner friendly"

@norraxx
Copy link
Collaborator Author

norraxx commented Aug 26, 2019

In python, there is chardet. Maybe we should use alternative way like: https://stackoverflow.com/questions/3759356/what-is-the-most-accurate-encoding-detector ?

@Kazbek
Copy link

Kazbek commented Nov 17, 2019

@norraxx I think that I solved this problem. This is pull request FAForever/faf-java-commons#31 .

mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this issue Apr 15, 2022
Fixes parsing of strings in lua bytestreams
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants