Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to open validation tool in browser to map upload #1565

Closed
badbwoi opened this issue Jan 28, 2020 · 4 comments
Closed

Add button to open validation tool in browser to map upload #1565

badbwoi opened this issue Jan 28, 2020 · 4 comments
Milestone

Comments

@badbwoi
Copy link

badbwoi commented Jan 28, 2020

Hello,
we are missing a link to the validation tool (https://api.faforever.com/maps/validate) in addition to the already added mapping rules (https://forums.faforever.com/viewtopic.php?f=2&t=17873) in the upload window/process.
image

The validation tool helps you check and validate your map name / content before upload. It also provides the right file names and pathing. Currently we are enforcing the rules while uploading a map and return these error messages. But the validation tool is not linked and some people don't know why they get this issue or how to solve it.
name_restriction
name_okay_names_given

Morax also supports the idea of the link.

My Dream Upload

While writing this I like to bring up a long desired dream of mine ;)
I believe the best error free upload can be achieved when we add the validation tool or its features to the upload process. Here are some ideas..

improve pre upload process
Encourage people to validate the map (name, scenario) before upload...

Option A:

  1. hit validate/check map button (needs to be added next to the upload map button)
    image
  2. open link to validation tool: https://api.faforever.com/maps/validate
  3. manual user input

Option B:

  1. hit validate/check map button (needs to be added next to the upload map button)
  2. select map
  3. auto-fill validation tool and show results online

improve upload process

  1. hit upload map button
  2. select map
  3. auto-fill validation tool and show results in upload window
  4. if rules are met and no errors remain the upload is possible, otherwise errors are displayed and explained
    4.1) server version: complete rewrite of the map files names (folder, scmap, save, script, options, tables, ...) and path (scmap, scenario, script,...) based on validated name = "map name" from scenario.lua -> this way removing .v0001 (from folder and in files) before upload is not a thing anymore
@badbwoi badbwoi changed the title add mapping rules and validation tool as link to upload process pls add validation tool to upload process Jan 28, 2020
@HurricanKai
Copy link

Imo with the new (?) restrictions on naming file names should also be renamed to -save -scenario -script to be consistent

Geosearchef added a commit that referenced this issue Jan 29, 2020
@Geosearchef
Copy link
Member

I added a button for now, a test within the client would be the best solution, but I advocate against that. It'll take way too much time away from more important developement tasks.

@badbwoi
Copy link
Author

badbwoi commented Jan 29, 2020

thx for the button.

what exactly are your referring to?
"a test within the client would be the best solution, but I advocate against that."

@Geosearchef
Copy link
Member

Geosearchef commented Jan 29, 2020

A system within the client that checks what you have selected and tells you what's wrong would be the best solution. But this takes too much time to be worth it for the small amount of people that use the map upload.

image

@Geosearchef Geosearchef reopened this Jan 29, 2020
@Geosearchef Geosearchef changed the title pls add validation tool to upload process Add button to open validation tool in browser to map upload Jan 29, 2020
Geosearchef added a commit that referenced this issue Jan 29, 2020
1-alex98 pushed a commit that referenced this issue Feb 8, 2020
add button for map validation tool
partial fix for prepares #1565
@1-alex98 1-alex98 added this to the v1.1.3 milestone Feb 9, 2020
@1-alex98 1-alex98 closed this as completed Feb 9, 2020
mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this issue Apr 15, 2022
add button for map validation tool
partial fix for prepares FAForever#1565
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants