Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation fails if ICE adapter is still open #1569

Closed
Brutus5000 opened this issue Jan 30, 2020 · 2 comments · Fixed by #1574
Closed

Update installation fails if ICE adapter is still open #1569

Brutus5000 opened this issue Jan 30, 2020 · 2 comments · Fixed by #1574
Labels
Milestone

Comments

@Brutus5000
Copy link
Member

Describe the bug
Sometimes the ICE adapter is still running after the client has been closed.
In that case the installation throws an error message that it can not create a file.

To Reproduce
Try to keep the ICE adapter alive? - then reinstall

Expected behavior
Installation works.

Screenshots
If applicable, add screenshots to help explain your problem.
image

OS
Windows

Idea for solution: Maybe the install4j installer can check that no ICE adapter process is running before installation.

Reported by visionik.

Wanna have the bug fixed quickly?
Visit Issue hunt...
Issue hunt

@Brutus5000 Brutus5000 added the bug label Jan 30, 2020
@1-alex98
Copy link
Member

1-alex98 commented Feb 8, 2020

Interesting

@1-alex98
Copy link
Member

1-alex98 commented Feb 9, 2020

@visionik said he closed it manually, so maybe try kill ice adapter if user closes client. Well we warn him already if the game is open i guess so that would be ok if u ask me

1-alex98 added a commit that referenced this issue Feb 9, 2020
1-alex98 added a commit that referenced this issue Feb 26, 2020
1-alex98 added a commit that referenced this issue Feb 29, 2020
1-alex98 added a commit that referenced this issue Feb 29, 2020
@1-alex98 1-alex98 linked a pull request Mar 3, 2020 that will close this issue
@1-alex98 1-alex98 added this to the v1.1.4 milestone Mar 3, 2020
mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this issue Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants