Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICE adapter sometimes not shutdown #1582

Closed
Brutus5000 opened this issue Feb 16, 2020 · 1 comment · Fixed by #1920
Closed

ICE adapter sometimes not shutdown #1582

Brutus5000 opened this issue Feb 16, 2020 · 1 comment · Fixed by #1920
Labels
Milestone

Comments

@Brutus5000
Copy link
Member

Describe the bug
The ICE adapter is not shutdown if the client fails to launch the game due to an exception.

To Reproduce
Steps to reproduce the behavior:

  1. Delete the ForgedAlliance.exe in C:\ProgramData\FAForever\bin (or whatever path you configured)
  2. Create an empty file and keep a write exclusive lock on the file
  3. Try to host a game: The client will try to download the file, but this will fail due to the write lock.

You can iterate step 3 as many times as you want, each iteration gives you a new lingering ice adapter process.

Expected behavior
If the client can't launch the game, kill the ice adapter process.

Screenshots
An armada of renegade ICE adapter tray icons.
grafik

OS
Windows

Wanna have the bug fixed quickly?
Visit Issue hunt...
Issue hunt

@Brutus5000 Brutus5000 added the bug label Feb 16, 2020
@1-alex98
Copy link
Member

Can not fully reproduce if I close the client however the ice adpter closes with it

1-alex98 pushed a commit that referenced this issue Sep 19, 2020
Stops iceAdapter when error occurs during game launch
Fixes #1582
@micheljung micheljung added this to the v1.2.1 milestone Sep 24, 2020
mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this issue Apr 15, 2022
Stops iceAdapter when error occurs during game launch
Fixes FAForever#1582
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants