Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add faction logo next to name in replay detail view #1645

Closed
FemtoZetta opened this issue Mar 29, 2020 · 0 comments · Fixed by #1646
Closed

Add faction logo next to name in replay detail view #1645

FemtoZetta opened this issue Mar 29, 2020 · 0 comments · Fixed by #1646
Milestone
v1.1.5

Comments

@FemtoZetta
Copy link
Contributor

Just like in the Python client you should see the faction of a player in the replay overview.
FemtoZetta added a commit that referenced this issue Mar 29, 2020
@FemtoZetta
#1645-add-faction-icon-replay-detail
0d0890a 
fixes #1645
-added coloured icons next to the name in the replay detail overview
-also fixed long names getting cut off and not being able to see the rating
-also fixed rating change being shown as "..." when there were long names
@FemtoZetta FemtoZetta mentioned this issue Mar 29, 2020
Merged
FemtoZetta added a commit that referenced this issue Mar 29, 2020
@FemtoZetta
#1645-add-faction-icon-replay-detail
deccd38 
fixes #1645
-added coloured icons next to the name in the replay detail overview
-also fixed long names getting cut off and not being able to see the rating
-also fixed rating change being shown as "..." when there were long names
FemtoZetta added a commit that referenced this issue Mar 29, 2020
@FemtoZetta
#1645-add-faction-icon-replay-detail
ee8c7e0 
fixes #1645
-added coloured icons next to the name in the replay detail overview
-also fixed long names getting cut off and not being able to see the rating
-also fixed rating change being shown as "..." when there were long names
FemtoZetta added a commit that referenced this issue Mar 29, 2020
@FemtoZetta
#1645-add-faction-icon-replay-detail
66e939a 
fixes #1645
-added coloured icons next to the name in the replay detail overview
-also fixed long names getting cut off and not being able to see the rating
-also fixed rating change being shown as "..." when there were long names
FemtoZetta added a commit that referenced this issue Mar 29, 2020
@FemtoZetta
#1645-add-faction-icon-replay-detail
a5cf346 
fixes #1645
-added coloured icons next to the name in the replay detail overview
-also fixed long names getting cut off and not being able to see the rating
-also fixed rating change being shown as "..." when there were long names
1-alex98 pushed a commit that referenced this issue Mar 29, 2020
@FemtoZetta
#1645-add-faction-icon-replay-detail (#1646)
69cd77d 
fixes #1645
-added coloured icons next to the name in the replay detail overview
-also fixed long names getting cut off and not being able to see the rating
-also fixed rating change being shown as "..." when there were long names
@1-alex98 1-alex98 added this to the v1.1.5 milestone Mar 30, 2020
@andreasley andreasley mentioned this issue Apr 10, 2020
Closed
mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this issue Apr 15, 2022
@FemtoZetta
FAForever#1645-add-faction-icon-replay-detail (FAForever#1646)
b498a64 
fixes FAForever#1645
-added coloured icons next to the name in the replay detail overview
-also fixed long names getting cut off and not being able to see the rating
-also fixed rating change being shown as "..." when there were long names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.5
Development

Successfully merging a pull request may close this issue.

#1645-add-faction-icon-replay-detail FAForever/downlords-faf-client
2 participants
@1-alex98 @FemtoZetta