Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users get stuck in the login screen waiting forever #1663

Closed
1 of 2 tasks
1-alex98 opened this issue Apr 2, 2020 · 1 comment
Closed
1 of 2 tasks

Users get stuck in the login screen waiting forever #1663

1-alex98 opened this issue Apr 2, 2020 · 1 comment
Labels
bug

Comments

@1-alex98
Copy link
Member

1-alex98 commented Apr 2, 2020 •
edited

Users do not seem to become a "welcome" message and get stuck loging in forever.

FAForever/server#562

Possible ways to improve the situation:

  • Make a timeout after which we cancle log in
  • Improve loging and catch and log potentially swallowed exceptions

User posting this on forum:
https://forums.faforever.com/viewtopic.php?f=3&t=18996&p=183021#p183021

Wanna have the bug fixed quickly?
Visit Issue hunt...
Issue hunt
@1-alex98 1-alex98 added the bug label Apr 2, 2020
1-alex98 added a commit that referenced this issue Apr 2, 2020
@1-alex98
Consider failing login task
8e65d84 
make sure the login future is completed exceptionally if anything unsuspected happens.
Prepares #1663
@1-alex98 1-alex98 mentioned this issue Apr 2, 2020
Merged
@Askaholic
Copy link
Collaborator

So in the server log I do see quite a few

Client <username> dropped. You have been signed out because you signed in elsewhere.

which might mean that old connections aren't being closed properly. Or maybe somehow people trigger two connections at the same time which kick each other out.

1-alex98 added a commit that referenced this issue May 19, 2020
@1-alex98
Consider failing login task (#1664)
dc71b4c 
make sure the login future is completed exceptionally if anything unsuspected happens.
Prepares #1663
mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this issue Apr 15, 2022
@1-alex98
Consider failing login task (FAForever#1664)
fe3a1c1 
make sure the login future is completed exceptionally if anything unsuspected happens.
Prepares FAForever#1663
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Askaholic @1-alex98