Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination of online replays #1764

Closed
Aclrian opened this issue Jun 9, 2020 · 2 comments
Closed

Pagination of online replays #1764

Aclrian opened this issue Jun 9, 2020 · 2 comments
Assignees
@Aclrian @jofaul @Tarmandan @FreZha
Labels
enhancement

Comments

@Aclrian
Copy link
Contributor

Aclrian commented Jun 9, 2020

Scrolling througth a huge size of replays is frustrating and replays older than 1 year are less relevant:
add a checkbox for only Replays from the last year
and a Pagination for a better overview
@jofaul jofaul self-assigned this Jun 10, 2020
@norraxx
Copy link
Collaborator

norraxx commented Jun 10, 2020

Or we could make "pages" not scrolling. Less memory consumption, faster client behavior.

@1-alex98
Copy link
Member

@norraxx pages are the suggestion...

jofaul added a commit that referenced this issue Jun 18, 2020
@jofaul
Merge branch 'develop' into feature/#1764-online-replays-pagination
8d26996
Aclrian added a commit that referenced this issue Jun 19, 2020
@Aclrian
adding functionality of the last year checkbox #1764
28e7e3f
Aclrian added a commit that referenced this issue Jun 29, 2020
@Aclrian
Pagination basics #1764
06e4978 
missing: max page count and pre-defined search doesn't work with current pagination
Aclrian added a commit that referenced this issue Jul 2, 2020
@Aclrian
adding functionality of the last year checkbox #1764
302703b
Aclrian added a commit that referenced this issue Jul 2, 2020
@Aclrian
Pagination basics #1764
e34945f 
missing: max page count and pre-defined search doesn't work with current pagination
Aclrian added a commit that referenced this issue Jul 2, 2020
@Aclrian
Merge branch 'feature/#1764-online-replays-pagination' of https://git…
4981cb2 
…hub.com/FAForever/downlords-faf-client into feature/#1764-online-replays-pagination
jofaul pushed a commit that referenced this issue Jul 6, 2020
@Aclrian @jofaul
adding functionality of the last year checkbox #1764
815fb99
jofaul pushed a commit that referenced this issue Jul 6, 2020
@Aclrian @jofaul
Pagination basics #1764
48a4fc3 
missing: max page count and pre-defined search doesn't work with current pagination
jofaul added a commit that referenced this issue Jul 6, 2020
@jofaul
Merge remote-tracking branch 'origin/feature/#1764-online-replays-pag…
927222a 
…ination' into feature/#1764-online-replays-pagination

# Conflicts:
#	src/main/java/com/faforever/client/replay/OnlineReplayVaultController.java
#	src/main/resources/theme/vault/replay/online_replays.fxml
jofaul added a commit that referenced this issue Jul 6, 2020
@jofaul
Merge remote-tracking branch 'origin/feature/#1764-online-replays-pag…
18051ed 
…ination' into feature/#1764-online-replays-pagination

# Conflicts:
#	src/main/java/com/faforever/client/api/FafApiAccessor.java
#	src/main/java/com/faforever/client/api/FafApiAccessorImpl.java
#	src/main/java/com/faforever/client/api/MockFafApiAccessor.java
#	src/main/java/com/faforever/client/remote/FafService.java
jofaul added a commit that referenced this issue Jul 6, 2020
@jofaul
Merge remote-tracking branch 'origin/feature/#1764-online-replays-pag…
6085f90 
…ination' into feature/#1764-online-replays-pagination

# Conflicts:
#	src/main/java/com/faforever/client/replay/OnlineReplayVaultController.java
jofaul pushed a commit that referenced this issue Jul 10, 2020
@Aclrian @jofaul
adding functionality of the last year checkbox #1764
d9167ea
jofaul pushed a commit that referenced this issue Jul 10, 2020
@Aclrian @jofaul
Pagination basics #1764
22b7477 
missing: max page count and pre-defined search doesn't work with current pagination
jofaul pushed a commit that referenced this issue Jul 10, 2020
@Aclrian @jofaul
adding functionality of the last year checkbox #1764
9fc99f1
jofaul added a commit that referenced this issue Jul 10, 2020
@jofaul
Merge remote-tracking branch 'origin/feature/#1764-online-replays-pag…
d689cf7 
…ination' into feature/#1764-online-replays-pagination

# Conflicts:
#	src/main/java/com/faforever/client/replay/OnlineReplayVaultController.java
jofaul added a commit that referenced this issue Jul 10, 2020
@jofaul
Merge remote-tracking branch 'origin/feature/#1764-online-replays-pag…
68dc1f3 
…ination' into feature/#1764-online-replays-pagination
jofaul added a commit that referenced this issue Jul 10, 2020
@jofaul
Merge branch 'feature/#1764-online-replay-pagination-seperate' into f…
e34bab6 
…eature/#1764-online-replays-pagination

# Conflicts:
#	src/main/java/com/faforever/client/replay/OnlineReplayVaultController.java
jofaul added a commit that referenced this issue Jul 14, 2020
@jofaul
Pagination Online Replay Vault
78c22d3 
Fixes #1764
jofaul added a commit that referenced this issue Jul 15, 2020
@jofaul @Tarmandan
@Aclrian @FreZha
Pagination Online Replay Vault
0ec84ab 
Fixes #1764

Co-Authored-By: tarmandan <58087411+tarmandan@users.noreply.github.com>
Co-Authored-By: aclrian <32142988+aclrian@users.noreply.github.com>
Co-Authored-By: Jia Hong Frenki Zhang <64331094+frezha@users.noreply.github.com>
Aclrian added a commit that referenced this issue Jul 22, 2020
@jofaul @Tarmandan
@Aclrian @FreZha
Pagination Online Replay Vault
c567d6f 
Fixes #1764

Co-Authored-By: tarmandan <58087411+tarmandan@users.noreply.github.com>
Co-Authored-By: aclrian <32142988+aclrian@users.noreply.github.com>
Co-Authored-By: Jia Hong Frenki Zhang <64331094+frezha@users.noreply.github.com>
1-alex98 pushed a commit that referenced this issue Jul 25, 2020
@jofaul @Tarmandan
@Aclrian @FreZha @1-alex98
Pagination Online Replay Vault
7b48f74 
Fixes #1764

Co-Authored-By: tarmandan <58087411+tarmandan@users.noreply.github.com>
Co-Authored-By: aclrian <32142988+aclrian@users.noreply.github.com>
Co-Authored-By: Jia Hong Frenki Zhang <64331094+frezha@users.noreply.github.com>
mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this issue Apr 15, 2022
@1-alex98 @Tarmandan
@Aclrian @FreZha @jofaul
online replays pagination
3466450 
Fixes FAForever#1764

Co-Authored-By: tarmandan <58087411+tarmandan@users.noreply.github.com>
Co-Authored-By: aclrian <32142988+aclrian@users.noreply.github.com>
Co-Authored-By: Jia Hong Frenki Zhang <64331094+frezha@users.noreply.github.com>
Co-authored-by: IAmAlife <54673768+IAmAlife@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aclrian Aclrian

@jofaul jofaul

@Tarmandan Tarmandan

@FreZha FreZha

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@1-alex98 @norraxx @Aclrian @jofaul @Tarmandan @FreZha