New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TMM: Distinguish between automatch and custom lobby games #1770
Projects
Comments
I'd rather suggest adding a game type as described in https://github.com/orgs/FAForever/projects/8 |
Sheikah45
added a commit
to Askaholic/downlords-faf-client
that referenced
this issue
Nov 6, 2020
Sheikah45
added a commit
to Askaholic/downlords-faf-client
that referenced
this issue
Nov 6, 2020
Sheikah45
pushed a commit
that referenced
this issue
Nov 6, 2020
Sheikah45
pushed a commit
that referenced
this issue
Nov 6, 2020
mrchris2000
pushed a commit
to mrchris2000/downlords-faf-client
that referenced
this issue
Apr 15, 2022
…FAForever#1949) * Check game_type instead of featured mod everywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now there is special handling for ladder games based on which featured mod the game is using. This needs to be extended to all matchmaker games in general. Since the plan is for matchmaker games to be played on an arbitrary featured mod, we need an additional property that determines if and where the lobby is displayed in the client.
We'll need to addinit_mode
to thegame_info
message sent by the server, and replace special logic which checks for the ladder featured mod to check for the init mode instead.We'll need to add
game_type
to thegame_info
message sent by the server. See the PR FAForever/server#635.FAForever/server#605
Wanna have the bug fixed quickly?
Visit Issue hunt...
The text was updated successfully, but these errors were encountered: