New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show all search results #1775
Comments
Basically you are proposing to filter the entire leaderboard based on the search term. So it will only show entries that match what you're typing. In that case it might be nice to have some way of easily jumping to that entry in the list while clearing the filter so you can see who is close to that player on the leaderboard. |
…sults' into feature/#1775-show-all-search-results
…sults' into feature/#1775-show-all-search-results # Conflicts: # src/main/java/com/faforever/client/leaderboard/LeaderboardController.java
Well with pagenation that the api supports that can be done... Similar to the leaderboard on the website |
…sults' into feature/#1775-show-all-search-results # Conflicts: # src/main/java/com/faforever/client/leaderboard/LeaderboardController.java
…sults' into feature/#1775-show-all-search-results
…sults' into feature/#1775-show-all-search-results # Conflicts: # src/main/java/com/faforever/client/api/FafApiAccessor.java # src/main/java/com/faforever/client/api/FafApiAccessorImpl.java # src/main/java/com/faforever/client/api/MockFafApiAccessor.java # src/main/java/com/faforever/client/leaderboard/LeaderboardController.java # src/main/java/com/faforever/client/leaderboard/LeaderboardService.java # src/main/java/com/faforever/client/remote/FafService.java # src/main/resources/theme/leaderboard/leaderboard.fxml
…sults' into feature/#1775-show-all-search-results
…sults' into feature/#1775-show-all-search-results
…sults' into feature/#1775-show-all-search-results
…sults' into feature/#1775-show-all-search-results # Conflicts: # src/main/java/com/faforever/client/api/FafApiAccessor.java # src/main/java/com/faforever/client/api/FafApiAccessorImpl.java # src/main/java/com/faforever/client/api/MockFafApiAccessor.java # src/main/java/com/faforever/client/leaderboard/LeaderboardController.java # src/main/java/com/faforever/client/leaderboard/LeaderboardService.java # src/main/java/com/faforever/client/remote/FafService.java # src/main/resources/theme/leaderboard/leaderboard.fxml
In the Leaderboards tab, the search is done as the user types something on the keyboard, showing the first matching item and the rest of users beneath it. This is however not practical and not efficient, thus it is aimed to narrow the search results down to users matching the input pattern:
ex. if "kr" is given, the results should look something like "krristi"; "kraboom" and so on.
The text was updated successfully, but these errors were encountered: