Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all search results #1775

Closed
krristi427 opened this issue Jun 16, 2020 · 2 comments · Fixed by #2159
Closed

Show all search results #1775

krristi427 opened this issue Jun 16, 2020 · 2 comments · Fixed by #2159
Milestone

Comments

@krristi427
Copy link
Collaborator

In the Leaderboards tab, the search is done as the user types something on the keyboard, showing the first matching item and the rest of users beneath it. This is however not practical and not efficient, thus it is aimed to narrow the search results down to users matching the input pattern:
ex. if "kr" is given, the results should look something like "krristi"; "kraboom" and so on.

@krristi427 krristi427 changed the title Show all hits Show all search results Jun 16, 2020
@Askaholic
Copy link
Collaborator

Basically you are proposing to filter the entire leaderboard based on the search term. So it will only show entries that match what you're typing. In that case it might be nice to have some way of easily jumping to that entry in the list while clearing the filter so you can see who is close to that player on the leaderboard.

Tim-eror added a commit that referenced this issue Jun 17, 2020
Tim-eror added a commit that referenced this issue Jun 18, 2020
…sults' into feature/#1775-show-all-search-results

# Conflicts:
#	src/main/java/com/faforever/client/leaderboard/LeaderboardController.java
@1-alex98
Copy link
Member

Well with pagenation that the api supports that can be done... Similar to the leaderboard on the website

Tim-eror added a commit that referenced this issue Jun 24, 2020
…sults' into feature/#1775-show-all-search-results

# Conflicts:
#	src/main/java/com/faforever/client/leaderboard/LeaderboardController.java
Tim-eror added a commit that referenced this issue Jun 24, 2020
Aksiznarf-Uar pushed a commit that referenced this issue Jul 8, 2020
…sults' into feature/#1775-show-all-search-results

# Conflicts:
#	src/main/java/com/faforever/client/api/FafApiAccessor.java
#	src/main/java/com/faforever/client/api/FafApiAccessorImpl.java
#	src/main/java/com/faforever/client/api/MockFafApiAccessor.java
#	src/main/java/com/faforever/client/leaderboard/LeaderboardController.java
#	src/main/java/com/faforever/client/leaderboard/LeaderboardService.java
#	src/main/java/com/faforever/client/remote/FafService.java
#	src/main/resources/theme/leaderboard/leaderboard.fxml
krristi427 added a commit that referenced this issue Jul 16, 2020
krristi427 added a commit that referenced this issue Jul 16, 2020
krristi427 added a commit that referenced this issue Jul 16, 2020
krristi427 added a commit that referenced this issue Sep 7, 2020
…sults' into feature/#1775-show-all-search-results

# Conflicts:
#	src/main/java/com/faforever/client/api/FafApiAccessor.java
#	src/main/java/com/faforever/client/api/FafApiAccessorImpl.java
#	src/main/java/com/faforever/client/api/MockFafApiAccessor.java
#	src/main/java/com/faforever/client/leaderboard/LeaderboardController.java
#	src/main/java/com/faforever/client/leaderboard/LeaderboardService.java
#	src/main/java/com/faforever/client/remote/FafService.java
#	src/main/resources/theme/leaderboard/leaderboard.fxml
@Sheikah45 Sheikah45 added this to the v1.4.3 milestone Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants