Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MapGen: Support major version changes #1781

Closed
Katharsas opened this issue Jun 18, 2020 · 0 comments · Fixed by #1803
Closed

MapGen: Support major version changes #1781

Katharsas opened this issue Jun 18, 2020 · 0 comments · Fixed by #1803
Milestone

Comments

@Katharsas
Copy link
Collaborator

Katharsas commented Jun 18, 2020

This is the first task that needs to be implemented in the client to complete proper argument handling for the map generator as described here: FAForever/Neroxis-Map-Generator#35

Basically, when the client

  • needs to know which map gen version it fully supports (example: client supports mapgen 1.8)
  • needs to check the major version number of the map name when doing anything with a give map name (like when joining existing mapgen game or starting replay of a mapgen game), for example lets say user tries to replay a game of mapgen version 2.0
  • if the major version differs (which is the case in this example), the client refuses to do the operation and tells the user that the client is not compatible and the user should probably update his client.

When this is in completed, new format for mapgen options can be introduced in mapgen 2.x like described in the mapgen issue.

Edit: Maybe a project should be created to include all related issues.

Issue hunt

@Katharsas Katharsas changed the title Map generator: Support major version changes MapGen: Support major version changes Jun 18, 2020
Sheikah45 added a commit to Sheikah45/downlords-faf-client that referenced this issue Jul 18, 2020
1-alex98 pushed a commit that referenced this issue Jul 19, 2020
Add UI to select options when creating a game with a generated map.
Fixes #1781
@1-alex98 1-alex98 added this to the v1.1.9 milestone Jul 21, 2020
mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this issue Apr 15, 2022
Add UI to select options when creating a game with a generated map.
Fixes FAForever#1781
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants