Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use proper pagination in Map vault #1799

Closed
micheljung opened this issue Jun 24, 2020 · 0 comments · Fixed by #1845
Closed

Use proper pagination in Map vault #1799

micheljung opened this issue Jun 24, 2020 · 0 comments · Fixed by #1845
Labels
beginner-friendly enhancement
Milestone
v1.2.0

Comments

@micheljung
Copy link
Member

JavaFX provides a Pagination Control.
It's very simple to use and should be used instead of our custom implementation in the map vault.

Other paginations should not be updated as part of this issue.
@Sheikah45 Sheikah45 linked a pull request Jul 23, 2020 that will close this issue
Feature/#1799 Map Vault Pagination #1839
Closed
@Sheikah45 Sheikah45 linked a pull request Aug 1, 2020 that will close this issue
Create Abstract Vault Controller #1845
Merged
1-alex98 pushed a commit that referenced this issue Aug 18, 2020
@Sheikah45
Create Abstract Vault Controller
c832e87 
Fixes #1814 
Fixes #1765
Fixes #1799 
Fixes #1660
@1-alex98 1-alex98 added this to the v1.2.0 milestone Aug 27, 2020
mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this issue Apr 15, 2022
@Sheikah45
Create Abstract Vault Controller
4f65dc6 
Fixes FAForever#1814 
Fixes FAForever#1765
Fixes FAForever#1799 
Fixes FAForever#1660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner-friendly enhancement
Projects
None yet
Milestone
v1.2.0
2 participants
@micheljung @1-alex98