Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leaderboard context menu #1800

Closed
Aksiznarf-Uar opened this issue Jun 25, 2020 · 5 comments
Closed

leaderboard context menu #1800

Aksiznarf-Uar opened this issue Jun 25, 2020 · 5 comments
Assignees

Comments

@Aksiznarf-Uar
Copy link

It would be nice to easily be able to find out information about a player you saw on the leaderboard.

I would like to add a context menu similar to the one you get when right-clicking on a player in the chat. It would show the following options: show user info, send private message, copy username, add/ remove friend, add/ remove foe, view replays.

@Aksiznarf-Uar Aksiznarf-Uar self-assigned this Jun 25, 2020
@micheljung
Copy link
Member

Or, given that the leaderboard table is quite empty anyways, we could add those actions as icons to each row. Therefore it's more visible and requires one less click.

@1-alex98
Copy link
Member

Would be an idea

krristi427 added a commit that referenced this issue Jun 28, 2020
…t-menu' into feature/#1800-leaderboard-context-menu

# Conflicts:
#	src/main/java/com/faforever/client/leaderboard/LeaderboardUserContextMenuController.java
Tim-eror added a commit that referenced this issue Jul 1, 2020
Tim-eror added a commit that referenced this issue Jul 1, 2020
krristi427 added a commit that referenced this issue Jul 8, 2020
Tim-eror added a commit that referenced this issue Jul 8, 2020
Aksiznarf-Uar pushed a commit that referenced this issue Jul 9, 2020
…t-menu' into feature/#1800-leaderboard-context-menu

# Conflicts:
#	src/main/java/com/faforever/client/leaderboard/LeaderboardController.java
#	src/main/java/com/faforever/client/leaderboard/LeaderboardService.java
#	src/main/java/com/faforever/client/leaderboard/LeaderboardUserContextMenuController.java
#	src/main/resources/theme/leaderboard/leaderboard_user_context_menu.fxml
#	src/test/java/com/faforever/client/leaderboard/LeaderboardServiceTest.java
krristi427 added a commit that referenced this issue Sep 24, 2020
…t-menu' into feature/#1800-leaderboard-context-menu

# Conflicts:
#	src/main/java/com/faforever/client/leaderboard/LeaderboardController.java
#	src/main/java/com/faforever/client/leaderboard/LeaderboardUserContextMenuController.java
@Sheikah45
Copy link
Member

Leaderboard is getting depreciated

@BlackYps
Copy link
Collaborator

BlackYps commented Oct 1, 2021

But it is still relevant for the league leaderboard

@BlackYps BlackYps reopened this Oct 1, 2021
@BlackYps BlackYps assigned BlackYps and unassigned Aksiznarf-Uar Oct 1, 2021
@Sheikah45
Copy link
Member

Already implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants