Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent assertions #1895

Closed
Brutus5000 opened this issue Sep 10, 2020 · 0 comments · Fixed by #1896
Closed

Consistent assertions #1895

Brutus5000 opened this issue Sep 10, 2020 · 0 comments · Fixed by #1896
Labels
enhancement

Comments

@Brutus5000
Copy link
Member

The assertions of state, null and not null is very inconsistent and not using the available Util methods.
Brutus5000 added a commit that referenced this issue Sep 10, 2020
@Brutus5000
Use consistent assert methods
70ce3b6 
fixes #1895
@Brutus5000 Brutus5000 mentioned this issue Sep 10, 2020
Merged
Brutus5000 added a commit that referenced this issue Sep 10, 2020
@Brutus5000
Use consistent assert methods
fd847a5 
fixes #1895
1-alex98 pushed a commit that referenced this issue Sep 13, 2020
@Brutus5000
Use consistent assert methods
5f4ac29 
fixes #1895
mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this issue Apr 15, 2022
@Brutus5000
Use consistent assert methods
54b48b4 
fixes FAForever#1895
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use consistent assert methods FAForever/downlords-faf-client
1 participant
@Brutus5000