Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join Discord Button #1933

Closed
micheljung opened this issue Sep 20, 2020 · 7 comments
Closed

Join Discord Button #1933

micheljung opened this issue Sep 20, 2020 · 7 comments
Assignees
Milestone

Comments

@micheljung
Copy link
Member

micheljung commented Sep 20, 2020

I think our Discord Server is still quite unknown. You'll only find it if someone tells you or you go to Menu > Links Overview > Discord

I'd like to have a prominent button for joining Discord.

@micheljung micheljung self-assigned this Sep 20, 2020
@FtXCommando
Copy link

It would be really good if there was a way to put such a button immediately on the new matchmaker tab. I feel like putting it in an area where you need to click 3 times to get it won't be as efficient for filling it with casual users.

@micheljung
Copy link
Member Author

This is my suggestion:

image

It's pretty much implemented, I just need to find out how to truly detach the process from the client.

@1-alex98
Copy link
Member

Let's do this I like it

@1-alex98
Copy link
Member

1-alex98 commented Sep 20, 2020

It would be really good if there was a way to put such a button immediately on the new matchmaker tab. I feel like putting it in an area where you need to click 3 times to get it won't be as efficient for filling it with casual users.

Waiting for things that not yet exist is not really a thing I like to do. Has not worked with ICE either XD

@1-alex98
Copy link
Member

1-alex98 commented Sep 20, 2020

This is my suggestion:

image

It's pretty much implemented, I just need to find out how to truly detach the process from the client.

Why don't you just open it in the browser? Cause not everybody has Discord installed. Browser finds out if it is installed.

@1-alex98
Copy link
Member

image

@micheljung
Copy link
Member Author

Why don't you just open it in the browser? Cause not everybody has Discord installed. Browser finds out if it is installed.

Because I have higher ambitions than that ;) it sucks when it needlessly opens the browser. Of course, I also covered the case where Discord isn't installed.

micheljung added a commit that referenced this issue Sep 21, 2020
micheljung added a commit that referenced this issue Sep 21, 2020
micheljung added a commit that referenced this issue Sep 21, 2020
micheljung added a commit that referenced this issue Sep 21, 2020
1-alex98 added a commit that referenced this issue Sep 22, 2020
@micheljung micheljung added this to the v1.2.1 milestone Sep 24, 2020
1-alex98 pushed a commit that referenced this issue Oct 4, 2020
Rename to `DiscordEventHandler`
Add button to join Discord

Fixes GH-1933
Sheikah45 pushed a commit that referenced this issue Nov 6, 2020
Rename to `DiscordEventHandler`
Add button to join Discord

Fixes GH-1933
mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this issue Apr 15, 2022
Rename to `DiscordEventHandler`
Add button to join Discord

Fixes FAForeverGH-1933
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants