Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate that a game include friends of your #1966

Closed
1-alex98 opened this issue Oct 1, 2020 · 8 comments · Fixed by #2264
Closed

Indicate that a game include friends of your #1966

1-alex98 opened this issue Oct 1, 2020 · 8 comments · Fixed by #2264
Milestone

Comments

@1-alex98
Copy link
Member

1-alex98 commented Oct 1, 2020

Is your feature request related to a problem? Please describe.
You are on Discord with your friends and they say they are in a game and it takes you 2 minutes till you understood which game you are supposed to join.

Describe the solution you'd like
Highlight the games a friend is in. Possibly with a smiley, the same that is used to indicate somebody is a friend in the player_card_tooltip.fxml (style class friend-icon). Though getting a better icon would also be appreciated. Needs to be done both in the game tiles and game table.

Wanna have the bug fixed quickly?
Visit Issue hunt...
Issue hunt

@Atrocyte
Copy link
Contributor

Atrocyte commented Nov 3, 2020

Fun feature, I've been looking into it.
The friend finding logic is done and in the table view friends are tracked with highlighting when they move from game to game.

image

I was thinking about adding a friend-icon smiley inside the players column, something like this: "4/12 😃".
Is that a suitable place for the smiley?

Atrocyte added a commit to Atrocyte/downlords-faf-client that referenced this issue Nov 9, 2020
Looks up online friends and matches these to the players inside the
game lobby.
Games with friends are highlighted

Fixes FAForever#1966
@Atrocyte
Copy link
Contributor

Atrocyte commented Nov 9, 2020

The games with friends will be highlighted and show a smiley to be extra obvious that a friend is in there.

Table formatting:
image

Tile formatting:
image

@1-alex98
Copy link
Member Author

this stupid smiley icon :D ... We will one day need to replace it with something proper

@1-alex98
Copy link
Member Author

untitled
... not the best designer

@1-alex98
Copy link
Member Author

We could post a call for an icon on forum :D Best icon wins

@Atrocyte
Copy link
Contributor

Oh yea that's a great idea @1-alex98 !

@1-alex98
Copy link
Member Author

or maybe somebody finds one in the internet that looks good

Atrocyte added a commit to Atrocyte/downlords-faf-client that referenced this issue Mar 1, 2021
Looks up online friends and matches these to the players inside the
game lobby.
Games with friends are highlighted

Fixes FAForever#1966
Sheikah45 pushed a commit that referenced this issue Jun 19, 2021
Co-authored-by: Ivan <v23620@gmail.com>
Sheikah45 pushed a commit that referenced this issue Jun 19, 2021
Co-authored-by: Ivan <v23620@gmail.com>
@Sheikah45 Sheikah45 added this to the v1.4.7 milestone Jun 20, 2021
@micheljung
Copy link
Member

mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this issue Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants