mentionPattern does not match names that end in -

[Askaholic]

People who's names end in - can't be pinged.

After messing around a bit, I think this is due to the \b word boundary matching. As - is not a word character, a space can never match after it (word boundary requires word before and non-word after, or vice versa). You can still ping these people if you put a letter directly after the - in order to trigger the word boundary matching.

Pattern p = Pattern.compile("\\b(" + "Box-" + ")\\b", CASE_INSENSITIVE);
Matcher m = p.matcher("I'm Box-");

System.out.println(m.find());
// Prints "false"

Matcher m2 = p.matcher("I'm Box-x");
System.out.println(m2.find());
// Prints "true"

Wanna have the bug fixed quickly?
Visit Issue hunt...

[Askaholic]

The fix is not complete as it doesn’t handle when the username is at the end of the line. It also doesn’t handle the case when the username starts with a dash.

[1-alex98]

One should have limited usernames to be alphanumeric only

[Sheikah45]

Yes I am not sure how much more extendable this is without introducing a bunch of false positive mentions

[Askaholic]

I think you can reproduce the behavior of \b but modify the “word” class to include dashes.

Something like ^|[^A-z-]USERNAME[^A-z-]|$ should do the trick.

I also firmly disagree that this is “untestable”. There should be at least a few tests that check stuff like:

• Box- matches Box-
• -Box matches -Box
• cardboard-Box does not match -Box
• Box-boy does not match Box-
• Hello Box-! matches Box-

[1-alex98]

I think you can reproduce the behavior of \b but modify the “word” class to include dashes.

Something like ^|[^A-z-]USERNAME[^A-z-]|$ should do the trick.

I also firmly disagree that this is “untestable”. There should be at least a few tests that check stuff like:

• Box- matches Box-
• -Box matches -Box
• cardboard-Box does not match -Box
• Box-boy does not match Box-
• Hello Box-! matches Box-

The actual code this is in

[Askaholic]

Btw using A-z for the character class was lazy phone typing and will include a few special characters like square brackets, which we probably don’t want.

[Sheikah45]

@Askaholic this pattern matches on just spaces as did @1-alex98. So this is not trivial it seems

[Sheikah45]

I think I was able to fix it