Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create a game with empty title using only whitespace #2420

Closed
Marc-Spector opened this issue Nov 18, 2021 · 2 comments · Fixed by #2424
Closed

Do not create a game with empty title using only whitespace #2420

Marc-Spector opened this issue Nov 18, 2021 · 2 comments · Fixed by #2424
Labels

Comments

@Marc-Spector
Copy link
Collaborator

Marc-Spector commented Nov 18, 2021

In the "Custom Games" tab, I saw the game with the empty title. The title contains only a whitespace.

Client Version:
2021.10.0

image

@Askaholic
Copy link
Collaborator

I’ll make a server issue as well. Should there be a minimum length for the title?

@Marc-Spector Marc-Spector changed the title Do not create a game with empty title using only space Do not create a game with empty title using only whitespace Nov 20, 2021
Sheikah45 pushed a commit that referenced this issue Nov 21, 2021
Co-authored-by: Ivan <v23620@gmail.com>
mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this issue Apr 15, 2022
@Askaholic
Copy link
Collaborator

Askaholic commented Jan 8, 2024

Checks for empty titles were added to the server in v1.14.0. Now I am seeing some errors in the log files which means the client' isn't properly sanitizing everything:

WARNING  Jan 06  22:47:22 LobbyConnection                Client error: Title must not be empty.
WARNING  Jan 06  20:43:46 LobbyConnection                Client error: Title must contain only ascii characters.

This is how the checks look on the server end

if not title.isascii():
    raise ClientError("Title must contain only ascii characters.")
if not title.strip():
    raise ClientError("Title must not be empty.")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants