New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try removing -Dprism.dirtyopts=false #2615
Labels
Comments
Is that the cause why loading bars cause insane cpu load? XD |
if so ... really important to get rid of it if possible :D |
1-alex98
added a commit
that referenced
this issue
Mar 17, 2022
Better performance, original bug not reproducible any more Fixes #2615
tested it does not seem to cause any issues with web views scrolling or webview scaling |
Merged
1-alex98
added a commit
that referenced
this issue
Mar 17, 2022
Better performance, original bug not reproducible any more Fixes #2615
Sheikah45
pushed a commit
that referenced
this issue
Mar 17, 2022
Better performance, original bug not reproducible any more Fixes #2615
mrchris2000
pushed a commit
to mrchris2000/downlords-faf-client
that referenced
this issue
Apr 15, 2022
Better performance, original bug not reproducible any more Fixes FAForever#2615
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The client has been using
-Dprism.dirtyopts=false
for a long time as a workaround for #442The problem is that this causes the whole UI to be rerendered even if just one pixel changes. This is especially bad when animations are used.
Back in time, I was able to reproduce the bug using the code from https://bugs.openjdk.java.net/browse/JDK-8089369
Right now, however, I'm no longer able to reproduce it with, not even with JDK 8 and JavaFX 11 so maybe it's fixed.
If we can make the client small, scroll all the way down or horizontally in a web view, and enlarge the client without this bug occurring, then it's probably fixed.
The text was updated successfully, but these errors were encountered: