Sorting options when searching for map or mod

[Garanas]

Is your feature request related to a problem? Please describe.

When searching in the vault you can only sort on name. This is unintuitive when searching for adaptive or survival maps as you are likely more interested in good adaptive / survival maps over those that happen to start with the letter a.

Describe the solution you'd like

You should be able to sort on:

• most recent maps / mods
• most valued maps / mods (using star system)
• most played maps / mods

And either of these should be the default, I'd argue it should be most valued as that keeps the most relevant maps on top and allows for shifts in the hierarchy that make sense. As an example, if you use most player then it may take years (if not more) for a map or mod to get onto the first page. But when using the most valued criteria it can be achieved within weeks.

Describe alternatives you've considered

I don't feel there is an alternative.

[Sheikah45]

This is actually a limitation of the underlying api that the vault uses that has been under work to improve here FAForever/faf-java-api#448

[Sheikah45]

Although I can look at which ones don't have the underlying limitation

[Sheikah45]

Ah yeah never mind can't sort over it because it doesn't support pagination

[Eternal-ll]

API works like a charm https://youtu.be/gnbehQYP-58

It is just sample, but with additional work it is possible to add multiple sorts i guess

[Sheikah45]

Eternal that only works for direct attributes of the objects, sorting will return an error if you try to sort over related object attributes

[bukajsytlos]

to be more specific, over one to many relation

…

On Fri, 17 Jun 2022, 16:27 Sheikah45, ***@***.***> wrote: Eternal that only works for direct attributes of the objects, sorting will return an error if you try to sort over related object attributes — Reply to this email directly, view it on GitHub <#2680 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACBYJJJNVS6P3UJM4D3OLBLVPSDM7ANCNFSM5UR7OLDQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[Eternal-ll]

https://api.faforever.com/data/mapVersion?include=map&sort=-map.gamesPlayed over map attributes from mapVersion

[bukajsytlos]

to be more more precise :)

//SQL does not support distinct and order by on columns which are not selected
                throw new InvalidValueException("Combination of pagination, sorting over relationship and"
                    + " filtering over toMany relationships unsupported");

Elide would in this conditions create query, which would sort over not selected fields.
More https://blog.jooq.org/how-sql-distinct-and-order-by-are-related/

[Sheikah45]

Does this mean we just have to include anything we sort?

[bukajsytlos]

https://api.faforever.com/data/mapVersion?include=map&sort=-map.gamesPlayed over map attributes from mapVersion

btw that's many to one

[bukajsytlos]

Does this mean we just have to include anything we sort?

theoretically, but it is not possible with one to many relationships. it would break pagination because of duplicates

[Sheikah45]

sounds good. For now I will close this though