Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixel Aliasing on the Newshub tab #2758

Closed
phongu opened this issue Jul 27, 2022 · 9 comments
Closed

Pixel Aliasing on the Newshub tab #2758

phongu opened this issue Jul 27, 2022 · 9 comments
Labels

Comments

@phongu
Copy link

phongu commented Jul 27, 2022

Describe the bug
Images and text on the newshub have jagged edges, compared to when viewed in firefox browser.
Screenshots
see comment below #2758 (comment)

@phongu phongu added the bug label Jul 27, 2022
@Brutus5000
Copy link
Member

Really strange as the client webview is based on Webkit just as Safari and Chrome

@phongu
Copy link
Author

phongu commented Jul 27, 2022

I've used other webkit implementations and have never seen this problem

@phongu phongu changed the title Webview does cheap, bad image scaling Bad image scaling on the news tab Jul 27, 2022
@JaviTrek
Copy link

1920x1080 image downscaled in the new newshub
image
image

I'm not sure if maybe it has to do with how the current newshub works but in my updated version, the images look quite fine. Not sure if its due to that on the current newshub, alot of images are 145x97 or other very small dimensions where one pixel can be quite the difference. But it seems this isn't an issue in the new implementation of the newshub.

@phongu
Copy link
Author

phongu commented Jul 27, 2022

Javii also suggested on discord that using
background-image: url() instead of
<img src="" /> to display the images might make the difference. I'm just leaving this comment here for future reference

@phongu
Copy link
Author

phongu commented Aug 6, 2022

well now the newshub update is public and i still see the issue

@phongu
Copy link
Author

phongu commented Aug 6, 2022

website
client

@phongu
Copy link
Author

phongu commented Aug 6, 2022

Plain HTML text is now aliased as well, in the screenshots above you can see the difference if you focus on the bold news titles

@phongu phongu changed the title Bad image scaling on the news tab Pixel Aliasing on the Newshub tab Aug 6, 2022
@phongu
Copy link
Author

phongu commented Aug 6, 2022

Eternal reports that Microsoft Edge webview2 sees the above content like this: image

The text is antialiased but the images are not

@phongu
Copy link
Author

phongu commented Sep 10, 2022

it's a known bug in microsoft edge apparently https://stackoverflow.com/questions/47443161/pixelated-image-downscaling-in-microsoft-edge

@phongu phongu closed this as not planned Won't fix, can't repro, duplicate, stale Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants