Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement that installed Mods and Maps are shown differently #702

Closed
1-alex98 opened this issue Jan 16, 2018 · 9 comments · Fixed by #1885
Closed

Implement that installed Mods and Maps are shown differently #702

1-alex98 opened this issue Jan 16, 2018 · 9 comments · Fixed by #1885

Comments

@1-alex98
Copy link
Member

Modify the ModCardControllers setInstalled() Method....
@20seven if you got time and fun doing it...

@20seven
Copy link
Contributor

20seven commented Jan 16, 2018

mapcards
do you mean something like this?

20seven pushed a commit that referenced this issue Jan 27, 2018
Added a label containing an icon to show the installed maps and mods as such
Fixes #702
@ghost ghost added the in progress label Jan 27, 2018
20seven pushed a commit that referenced this issue Jan 27, 2018
Added a label containing an icon to show the installed maps and mods as such
Fixes #702
@20seven
Copy link
Contributor

20seven commented Jan 27, 2018

This works fine now, but when testing on MapCards it cannot update the installedLabel on uninstall. I think it could be related to issue #525 .

I have a green "arrow pointing down to a hard drive"-icon. It might follow the scheme better if it's white as the rest of the text, just let me know if i should change it.

@1-alex98
Copy link
Member Author

#525 is really a pain

@1-alex98
Copy link
Member Author

We need to be careful with red and green, as people are colour blind, but yeah... I don't know. I am not good when it comes to design :D @micheljung

@micheljung
Copy link
Member

micheljung commented Feb 7, 2018

Icons are always better than text

  1. They don't need a color to be meaningful (making it not only color-blindness friendly but also theme-friendly (even though themes could override the color))
  2. They don't need to be translated (Less work, no different text lengths to be considered)
  3. They look better

But it's not always easy to find an icon that is meaningful ;)

@20seven
Copy link
Contributor

20seven commented Feb 25, 2018

installed map

@micheljung how about this? (gap is installed, Waters of Isis is not)

@1-alex98
Copy link
Member Author

Seems reasonable to me

20seven pushed a commit that referenced this issue Mar 22, 2018
Added a label containing an icon to show the installed maps and mods as such
Fixes #702
20seven pushed a commit that referenced this issue Mar 25, 2018
Added a label containing an icon to show the installed maps and mods as such
Fixes #702
@Sheikah45
Copy link
Member

Is this still desired?

@1-alex98
Copy link
Member Author

I would say so. Maybe use the new way for icons then tho maybe

1-alex98 pushed a commit that referenced this issue Sep 13, 2020
Add install button to map and mod cards for easier UX for installing
Fixes #1874, Fixes #702
@micheljung micheljung added this to the v1.2.1 milestone Sep 24, 2020
mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this issue Apr 15, 2022
Add install button to map and mod cards for easier UX for installing
Fixes FAForever#1874, Fixes FAForever#702
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants