Refactor IRC Chatservice #1354
Closed
Refactor IRC Chatservice #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed ChatService to OldChatService - New ChatServiceAdapter class that implements OldChatService passes calls to specializes services for compatibility - ChatServiceImpl does not implement OldChatService anymore, moved any chat room specific code to new ChatRoomService
Katharsas
force-pushed
the
refactor/#1336-irc-chatservice
branch
from
f0bd600
to
41517ef
Compare
|
U got 1 Month till I close it |
|
U can reponen if it was reworked and is ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is not ready yet, but i want people to be able to find/test/comment on this branch, so here we go : )
Some notes:
ChatServiceImplTestis disabled for now because these tests need to be restructured/rewritten which i will attempt to do once i get some feedback about this whole thing.Implements #1336