Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preferences file read after deletion #1627

Merged
merged 1 commit into from Mar 22, 2020
Merged

Preferences file read after deletion #1627

merged 1 commit into from Mar 22, 2020

Conversation

1-alex98
Copy link
Member

Fixes #1626

Geosearchef
Geosearchef approved these changes Mar 21, 2020
View reviewed changes
src/main/java/com/faforever/client/preferences/PreferencesService.java
}
return false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

else { return false; }

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no why???

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cause it's ten times more readable. No need to use the "abort" case here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do this code style all over the application

@1-alex98 1-alex98 merged commit 44c7059 into develop Mar 22, 2020
@Brutus5000 Brutus5000 deleted the bugfix/#1626-settings-empty-results-in-error branch November 4, 2020 21:40
mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this pull request Apr 15, 2022
@1-alex98
Preferences file read after deletion (FAForever#1627)
7f720e8 
Fixes FAForever#1626
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Geosearchef Geosearchef Geosearchef approved these changes

@andreasley andreasley Awaiting requested review from andreasley

@Brutus5000 Brutus5000 Awaiting requested review from Brutus5000

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error about preferences broken blocking user from launching client
2 participants
@1-alex98 @Geosearchef