update java and java fx versions #1707
Conversation
build.gradle
Outdated
| sourceCompatibility = JavaVersion.VERSION_1_10 | ||
| targetCompatibility = JavaVersion.VERSION_1_10 | ||
| sourceCompatibility = 1.11 | ||
| targetCompatibility = 1.11 |
| @@ -1,6 +1,6 @@ | |||
| #Mon Jan 30 18:27:36 CET 2017 | |||
| #Sat May 02 19:00:33 CEST 2020 | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-6.1.1-all.zip | |||
There was a problem hiding this comment.
I can hardly believe that we jump more than 6 (?) version without major issues? From my experience there is always a lot of stuff broken. Did you really test this with the new wrapper? (Especially since you removed the wrapper task.)
There was a problem hiding this comment.
Yes and removing the wrapper task was one thing that I needed to do to get it to work...
There was a problem hiding this comment.
We have the latest Gradle running with wrapper task at work. This is suspicious. Makes me think that then Travis just uses an older Gradle version.
There was a problem hiding this comment.
Well instead of overwritting you can edit it yes I can do that instead
There was a problem hiding this comment.
Look at @micheljung PR he does the same :D
There was a problem hiding this comment.
I was surprised, too, but I executed some Gradle tasks and there were no problems :)
1-alex98
force-pushed
the
feature/#1675-update-stuff
branch
from
2a73c34
to
2ad7a43
Compare
|
Sadly the RC does not build it has somthing to do with certs at Install4j download server |
* Update java fx and java jre Fixes FAForever#1675 * Clean up CLI * Update Gradle * Fix coveralls by update * Try fix cert errors * Install new java * Install new java * Correct jdk name * Install new java * Fix WebViewPatcher * Add note about changes * Update to Gradle 6.5
Not sure if we should merge it. There are a lot of crashes for me lately and they might be caused by this