Rework of sub-tabs #1715
Merged
Rework of sub-tabs #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1-alex98
requested changes
May 24, 2020
Comment on lines
80
to
86
| @Override | ||
| protected void onHide() { | ||
| customGamesController.hide(); | ||
| ladderController.hide(); | ||
| coopController.hide(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Why delete that? That should not be done
1-alex98
approved these changes
May 24, 2020
| playRootTabPane.getSelectionModel().select(coopTab); | ||
| coopController.display(navigateEvent); | ||
| lastTab = coopController; | ||
| } else if (Objects.equals(navigateEvent.getClass(), NavigateEvent.class)) { | ||
| lastTab.display(navigateEvent); |
Merged
mrchris2000
pushed a commit
to mrchris2000/downlords-faf-client
that referenced
this pull request
Apr 15, 2022
* rearrange subtabs and highlight them more * restore onHide function * call onHide instead of hide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1712
Fixes #1713
Fixes #1714