Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert show/hide details button in custom games to icon #1717

Merged
merged 1 commit into from
Jun 20, 2020
Merged

convert show/hide details button in custom games to icon #1717

merged 1 commit into from
Jun 20, 2020

Conversation

BlackYps
Copy link
Collaborator

The button now takes less space and is more on the right

@1-alex98
Copy link
Member

Screenshot would be nice :D... guess have to look at it for myself

@BlackYps
Copy link
Collaborator Author

grafik

1-alex98
1-alex98 previously approved these changes May 27, 2020
View reviewed changes
@BlackYps BlackYps force-pushed the feature/details-icon-button branch from 3583057 to aa0c94c Compare May 28, 2020 12:18
@BlackYps
Copy link
Collaborator Author

Changed the icon:

grafik

Fixes #1732

@BlackYps BlackYps force-pushed the feature/details-icon-button branch from aa0c94c to 0b588cd Compare May 28, 2020 12:39
@1-alex98
Copy link
Member

I really liked the first one better. The windows arrows are also that way on the other site the vault now has the other arrows so I guess we at least need to make it consistent.

@Katharsas
Copy link
Collaborator

I think its important to make it completely clear which parts of the GUI are interactive and which are not. If buttons are added, they should imo look like buttons, so i would add some background color change to this. The Table/Tiles view switch could also use that.

@BlackYps
Copy link
Collaborator Author

I don't really get what windows arrows you mean, but I agree that the first one was better.
I made it look more like a normal button now, that kind of sits on the edge that it is supposed to collapse:
I also fixed the Table/Tiles toggle buttons, so they look consistent to other buttons.
grafik

@BlackYps BlackYps force-pushed the feature/details-icon-button branch from 0b588cd to 73b14cc Compare May 29, 2020 13:26
@BlackYps BlackYps requested a review from 1-alex98 June 18, 2020 16:57
@1-alex98 1-alex98 force-pushed the feature/details-icon-button branch from 73b14cc to 21e569e Compare June 20, 2020 13:42
@1-alex98
Copy link
Member

merging as soon as tests run through... tell me if forget

@1-alex98 1-alex98 merged commit 0deea5e into FAForever:develop Jun 20, 2020
@1-alex98 1-alex98 linked an issue Jun 20, 2020 that may be closed by this pull request
Turn show/hide details button in custom games into an icon #1732
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1-alex98 1-alex98 Awaiting requested review from 1-alex98

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Turn show/hide details button in custom games into an icon
3 participants
@BlackYps @1-alex98 @Katharsas