Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocate "more" buttons #1729

Merged

Conversation

BlackYps
Copy link
Collaborator

Fixes #1728

Replay Vault:
grafik

Map/Mod Vault:
grafik
The button is part of the flow pane, but it looks a bit odd. If you have suggestions to improve it visually, let me know.

@Katharsas
Copy link
Collaborator

Map/Mod vault idea: Make button height as big as a tile (100%), allign it left in the tile and rename it to ">>".

@1-alex98
Copy link
Member

@Katharsas might look good, not sure but does in my imagination

@Katharsas
Copy link
Collaborator

Would work better with proper icons i guess that look like actual arrow heads.

@BlackYps
Copy link
Collaborator Author

something like this?
grafik

@BlackYps
Copy link
Collaborator Author

This is probably better:
grafik

1-alex98
1-alex98 previously approved these changes May 27, 2020
Copy link
Member

@1-alex98 1-alex98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still need to test it before merge tho

@BlackYps
Copy link
Collaborator Author

Yeah, don't merge it yet. the new button is just a mockup, I have to implement it properly yet.

@Katharsas
Copy link
Collaborator

Yeah basically. I would prefer the icon to be a little bit smaller (but keep width of button) xD

@BlackYps
Copy link
Collaborator Author

grafik

Copy link
Member

@1-alex98 1-alex98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs more button on owned maps

@1-alex98 1-alex98 merged commit 5b3204b into FAForever:develop May 27, 2020
mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this pull request Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"More" Buttons in the vault are in strange positions
3 participants