Fix bug in handling of navigation events #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1-alex98
previously approved these changes
Jul 13, 2020
| if (navigateEvent instanceof OpenGlobalLeaderboardEvent) { | ||
| leaderboardRoot.getSelectionModel().select(globalLeaderboardTab); | ||
| globalLeaderboardController.display(navigateEvent); | ||
| else if (navigateEvent instanceof OpenGlobalLeaderboardEvent) { |
1-alex98
reviewed
Jul 13, 2020
|
Testing if the correct tab is opened is not enough. We would need to test that it actually shows the ladder maps and not the front page of the map vault. you can actually see that it did that for a brief moment and then the second navigate event resetted the view to the start view. I don't know how to test for this properly. We could try to test if mapService.getLadderMaps() got called, but that would have passed even with this bug... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1807
Posting a navigation event when initializing a tab had side effects when a navigate event (e.g. clicking on the show ladder maps button) took you to a previously uninitialized tab, because that would also trigger the event in initialize().
If we want that, the new behaviour could be improved even further by writing the lastTab information to the preferences, so the client can remember which tabs you had open even over a restart.