Bugfix/#2024 Filtering users in chat makes chat only users disappear forever #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs for typing on username search field
Marc-Spector
force-pushed
the
bugfix/#2024-filtering-users-in-chat-only-group
branch
from
dd9657a
to
0b8cd0c
Compare
|
The PR is ready to review |
Brutus5000
requested changes
Nov 15, 2020
src/main/java/com/faforever/client/chat/UserFilterController.java
Outdated
Show resolved
Hide resolved
Brutus5000
approved these changes
Nov 17, 2020
mrchris2000
pushed a commit
to mrchris2000/downlords-faf-client
that referenced
this pull request
Apr 15, 2022
…isappear forever (FAForever#2038) * FAForever#2024 fix a bug when all users of 'chat only' group disappears for typing on username search field Co-authored-by: Ivan <v23620@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2024
I wanted to add tests to test the list of users when using filters to avoid these errors in the future, but I have no idea how to do it.Added unit tests to avoid these errors in the future